fix(thorchain/utxo): fix race conditions #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
I wanted to give you a heads up, #1270 introduces some changes that are going to affect the thorchain/utxo stuff you are working on. I just finished linting the codebase and re-adding the linter as a required status check in CI and one major change I needed to make was passing in a |
Reecepbcups
approved these changes
Oct 8, 2024
Comment on lines
+59
to
+64
| for _, chain := range chains { | ||
| utxoChain, ok := chain.(*utxo.UtxoChain) | ||
| if ok { | ||
| utxoChain.Stop() | ||
| } | ||
| } |
There was a problem hiding this comment.
Not for this PR, but if this always needs to be called it may make sense to move into the ic.Close() func?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few race conditions on thorchain and utxo chains.
Thorchain: sidecar processes now get their own copy of env list so they can make runtime changes in parallel.
Utxo: reading and writing KeynameToWalletMap and AddrToKeynameMap is now protected by a mutex. The block producing go routine is now ran after faucet creation and a utxo stop method is added for the test framework to cancel its context.
Thorchain's setup_test.go is updated to call the utxo chain's stop method. This will also be reflected in the thornode v50 branch.