From dca06a5c29fc3a7d37eb8ce9600148e61633a1b1 Mon Sep 17 00:00:00 2001 From: Raul Date: Fri, 15 Dec 2023 20:23:21 -0500 Subject: [PATCH] inconsistency in licensing roles --- contracts/lib/AccessControl.sol | 2 -- contracts/modules/licensing/LicensingFrameworkRepo.sol | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/contracts/lib/AccessControl.sol b/contracts/lib/AccessControl.sol index f5de07a1..4077eb6c 100644 --- a/contracts/lib/AccessControl.sol +++ b/contracts/lib/AccessControl.sol @@ -30,6 +30,4 @@ library AccessControl { // Role that can execute Hooks bytes32 public constant HOOK_CALLER_ROLE = keccak256("HOOK_CALLER_ROLE"); - // Role to set legal terms in TermsRepository - bytes32 public constant LICENSING_MANAGER = keccak256("LICENSING_MANAGER"); } diff --git a/contracts/modules/licensing/LicensingFrameworkRepo.sol b/contracts/modules/licensing/LicensingFrameworkRepo.sol index 2981d407..3b9acf5f 100644 --- a/contracts/modules/licensing/LicensingFrameworkRepo.sol +++ b/contracts/modules/licensing/LicensingFrameworkRepo.sol @@ -47,7 +47,7 @@ contract LicensingFrameworkRepo is AccessControlled, Multicall { /// @dev this is an admin only function, and can only be called by the /// licensing manager role /// @param input_ the input parameters for the framework - function addFramework(Licensing.SetFramework calldata input_) external onlyRole(AccessControl.LICENSING_MANAGER) { + function addFramework(Licensing.SetFramework calldata input_) external onlyRole(AccessControl.LICENSING_MANAGER_ROLE) { FrameworkStorage storage framework = _frameworks[input_.id]; if (framework.paramTags.length() > 0) { revert Errors.LicensingFrameworkRepo_FrameworkAlreadyAdded();