Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Use OpenShift console timestamp component #4117

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KevinFCormier
Copy link
Contributor

Makes the <Timestamp /> component from OpenShift console available and simplifies the current mechanism for using console dynamic plugin SDK hooks and components while maintaining the ability to run in standalone mode.

The <Timestamp /> component gives us an easy way to have consistent display of timestamps that are localized.

Placeholder for standalone dev mode:
image

Demonstrating translated date/time string (French) and tooltip, with icon removed:
image

Relative time display (once the current bug is implemented):
image

TODOs:

  • Implement a simplified version of the component for standalone development use
  • Implement a wrapper component to handle removing the icon (which we will not want to use in a table context)
  • Contribute a fix for the broken relative string support (see draft PR Fix Timestamp relative display openshift/console#14555)

Copy link

openshift-ci bot commented Nov 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented Nov 29, 2024

@vishsanghishetty
Copy link
Contributor

@KevinFCormier, thanks for making the changes, these look good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants