Add RAII support for File class #67
Conversation
When a File object goes out of scope, its resources are not freed. This patch: - Adds a destructor to free this memory and close the file handle when the object is destroyed. - Deletes the copy constructor and copy assignment operator, as this class is not copyable (at least, not without more significant future work). - Adds move semantics. --- Fixes #66.
|
CI fails because the example sketches are broken and attempt to copy the file structure. I can either fix the examples or implement copying for this class. |
|
I suggest fixing the examples. Copying a file handle like this is generally discouraged and can cause some really awful problems. The offending example could easily be fixed by taking |
|
Well example is based on the official example. |
|
Ah, that is a bit annoying. I could implement copying for files here, but that's definitely not recommended... Perhaps it would be best to close this PR. It's not the first time I've run into Arduino's C++ code being sub-par :/ To implement copying, it's trivial to duplicate the file name, but I don't think there's any reasonable way to manage copies of the file handle itself. Re-opening isn't an option, as this will break if file locking is enabled, and if it's not, could lead to potential races. Copying the file handle directly would work, but then if one copy closes the file, the other is in an unknown state. As this also applies to the existing implementation, it's probably not worth changing. |
|
Anyway, I understand your point and it is valid. |
When a File object goes out of scope, its resources are not freed. This patch:
Fixes #66.