From 1efc121466247f046460aeca207c5c744eb97dbe Mon Sep 17 00:00:00 2001 From: James Carter Date: Fri, 14 Jun 2024 15:45:00 -0400 Subject: [PATCH] libsepol: Do not reject all type rules in conditionals when validating MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Commit 1c91bc84 ("libsepol: reject self flag in type rules in old policies") actually rejects all type rules in conditionals in modular policies prior to version 21 (MOD_POLICYDB_VERSION_SELF_TYPETRANS). The problem is because of fall-through in a switch statement when the avrule flags are 0. Instead, break rather than fall-through when avrule flags are 0. Reviewed-by: Christian Göttsche Acked-by: Petr Lautrbach --- libsepol/src/policydb_validate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libsepol/src/policydb_validate.c b/libsepol/src/policydb_validate.c index 9746f562c..2043e4379 100644 --- a/libsepol/src/policydb_validate.c +++ b/libsepol/src/policydb_validate.c @@ -1076,6 +1076,7 @@ static int validate_avrules(sepol_handle_t *handle, const avrule_t *avrule, int switch(avrule->flags) { case 0: + break; case RULE_SELF: if (p->policyvers != POLICY_KERN && p->policyvers < MOD_POLICYDB_VERSION_SELF_TYPETRANS &&