Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't handle zero sebetahats correctly #84

Open
willwerscheid opened this issue Jul 25, 2018 · 4 comments
Open

doesn't handle zero sebetahats correctly #84

willwerscheid opened this issue Jul 25, 2018 · 4 comments

Comments

@willwerscheid
Copy link
Contributor

For example, ash(betahat = c(1, 2, 3, 4), sebetahat = c(0, 0, 1, 1)) gives me posterior means of zero for the first two observations.

@willwerscheid
Copy link
Contributor Author

We might want to handle infinite SEs too, possibly by throwing an error. (We can get infinite SEs in flash.)

@willwerscheid
Copy link
Contributor Author

calc_pm automatically sets these cases (covered by get_exclusions) to have a mean of zero and a SD of zero. We should change this: zero SEs should return mean = x, sd = 0; infinite SEs and NAs should return prior mean and sd.

@willwerscheid
Copy link
Contributor Author

Issue #59 can be addressed as part of the same fix.

@willwerscheid
Copy link
Contributor Author

Infinite SEs also screw up the returned log likelihood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant