Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace embedded SVG images in the Yomitan version with HTML/CSS #29

Closed
stephenmk opened this issue Dec 22, 2023 · 2 comments
Closed

Replace embedded SVG images in the Yomitan version with HTML/CSS #29

stephenmk opened this issue Dec 22, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@stephenmk
Copy link
Owner

stephenmk commented Dec 22, 2023

Now that Yomitan has had its first stable release and development activity has taken off, it's possible for new features to be implemented.

As far as Jitendex is concerned, I think my top priority is replacing the embedded SVG files with pure HTML/CSS markup as is done with the Mdict (MDD/MDX) version. For a variety of reasons, SVG images are a clumsy way to implement the tag functionality.

Replacing the SVG files will require quite a few new style attributes to be supported by Yomitan. Here's a provisional list.

  • padding-top
  • padding-right
  • padding-bottom
  • padding-left
  • word-break
  • color
  • background-color
  • border-color
  • border-style
  • border-radius
  • cursor

The "title" attribute is already implemented for images in Yomitan, but it will need to be allowed for other generic container types as well (div, span) in order for hover-text to work with these tag icons.


Unrelated to the SVG images, I'd also like to add some more text-decoration styles in order to make keywords in example sentences more visible (as in the Mdict version).

  • text-decoration-style
  • text-decoration-color

New fieldset and legend containers could also be implemented so that supplemental information (example sentences, cross references, usage notes, etc.) could be drawn in a rectangular box with a title. People might prefer the current (more compact) style of the Yomitan version, though.

@stephenmk stephenmk added the enhancement New feature or request label Dec 22, 2023
@stephenmk stephenmk self-assigned this Dec 22, 2023
@stephenmk
Copy link
Owner Author

I submitted some code edits to Yomitan to enable these features. The changes have been merged and will presumably be available in the next release of the program.

yomidevs/yomitan#450

Once this new version of Yomitan is available, I will publish a new version of Jitendex for Yomitan without the embedded SVG icons.

@stephenmk
Copy link
Owner Author

Implemented in version 4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant