Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHC 9.2 support is missing #16

Open
Kleidukos opened this issue Sep 14, 2022 · 5 comments
Open

GHC 9.2 support is missing #16

Kleidukos opened this issue Sep 14, 2022 · 5 comments

Comments

@Kleidukos
Copy link

Hi! I'd like to start using plugins for an application of my own.

I tried to depend on it with GHC 9.2 as my compiler, and the following message makes me think that plugins is still trying to look up the old module hierarchy:

src/System/Plugins/LoadTypes.hs:33:1: error:
    Could not find module ‘HscTypes’
    Use -v (or `:set -v` in ghci) to see a list of the files searched for.
   |
33 | import HscTypes
   | ^^^^^^^^^^^^^^^

You're probably busy, so would you accept a PR to fix this?

@stepcut
Copy link
Owner

stepcut commented Sep 14, 2022

Yes. In fact, accepting PRs and uploading a new version to hackage is the only work I do on this package.

@Kleidukos
Copy link
Author

Got it! Thanks for being reactive. :)

@Kleidukos
Copy link
Author

@stepcut Hi! @cgibbard and I have ported the package to the latest GHC releases. Due to the copious amount of CPP involved for (what are frankly ancient) versions of GHC, I wanted your permission to switch the support window to GHC 8.10 minimum. What do you think of this?

@stepcut
Copy link
Owner

stepcut commented Sep 23, 2022

Given the limited number of users of this package, GHC 8.10 sounds reasonable. If someone really needs to use an older compiler, they can just use an older version of the plugin. I say that as someone who is still using GHC 8.6.5 :)

@bleedsa
Copy link

bleedsa commented Mar 2, 2024

I'm still getting this error with ghc 9.0.2, has anyone figured out a fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants