Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a mutex to backend ledger transaction_count and operation_count sums #286

Open
acharb opened this issue Jun 13, 2022 · 1 comment
Open
Labels

Comments

@acharb
Copy link
Contributor

acharb commented Jun 13, 2022

when looking at the ledgers endpoints for dashboard-v2 and dashboard v1 (in prod now) I noticed the tx and op count data are slightly different. I'm guessing it's due to using data in memory as part of the sum equation in the updateCache method, in which case a mutex may help (maybe async-mutex). But some further investigation is probably needed.

Not high priority, they're all fairly close (~95% or higher), and this data is mostly used for visually comparing days in the UI, so data doesn't need to be exact.

@acharb acharb added the backend label Jun 13, 2022
@acharb
Copy link
Contributor Author

acharb commented Jun 13, 2022

the keys are different for v1 and v2, that could be also affecting which ledgers are included in each day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant