Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

Lite updates on confirm.html #87

Open
theclabs opened this issue Aug 27, 2019 · 1 comment
Open

Lite updates on confirm.html #87

theclabs opened this issue Aug 27, 2019 · 1 comment

Comments

@theclabs
Copy link

In the next line there is a var in camelCase, the norm is snake-case. its show a "undefined" error in confirm page.

https://github.com/stellar/sep6-demo-client/blob/e9304206633c2a6fb7ab392e6f212311ad9098f2/src/steps/withdraw/poll_for_success.js#L31

I suggest some small improvements in the UI to show dynamic data. I have the fork with the mods and I plan to add all balances and assets to the main screen.

image

@msfeldstein
Copy link
Contributor

Yep we should definitely make those dynamic. You can do this by passing query parameters and use the [data-replace] attribute to replace those properties

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants