This repository has been archived by the owner on Sep 12, 2019. It is now read-only.
Pre-emptive documentation for #36 #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After all the discussion in stellar-deprecated#36, this attempts to improve the README for compliance server to explain how `/allow_access`, `/remove_access`, and `callbacks.ask_user` are intended to work together. NOTE the current code does not reflect this documentation; it still needs to be updated to fix stellar-deprecated#36.
Mr0grog
force-pushed
the
clarify-allow-access-and-ask-user
branch
from
af68bc0 to
a1828fa
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not fix #36 and probably shouldn’t be merged until the code is fixed as well.
After all the discussion in #36, this attempts to improve the README for compliance server to explain how
/allow_access,/remove_access, andcallbacks.ask_userare intended to work together.This is documentation only, so we probably don’t want to merge it by itself. Ideally we can just merge this into the actual code fixes whenever they come along.