Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept custom providers in the configuration #122

Open
elcuro opened this issue Dec 11, 2019 · 1 comment
Open

Accept custom providers in the configuration #122

elcuro opened this issue Dec 11, 2019 · 1 comment

Comments

@elcuro
Copy link

elcuro commented Dec 11, 2019

Allow to enable/disable custom providers in the config sitemap.providers. Only core providers can be enabled/disabled now.

InvalidConfigurationException

Unrecognized option "cms_sections" under "sylius_sitemap.providers". Available options are "products", "static", "taxons".

It will be useful for plugins which works with the sitemap plugin. E.g. https://github.com/BitBagCommerce/SyliusCmsPlugin/blob/master/doc/sitemap.md

@stefandoorn
Copy link
Owner

Sounds useful @elcuro, but I doubt if this shouldn't be the responsibility of the other plugin to enable/disable this, or register/unregister it. I'm trying to think of a way to handle this best while keeping configuration sane. Do you have a suggestion and are you able to provide a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants