Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet)_: Remove EIP-3770 address format #21995

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(wallet)_: Remove EIP-3770 address format #21995

wants to merge 1 commit into from
+247 −621

Conversation

smohamedjavid
Copy link
Member

fixes #21958

Summary

This PR:

  • removes EIP-3770 address format (with chain prefix) from the UI and displays/uses only the address
  • removes editing of preferred networks for an account and saved address
  • copy/paste functions will remove the chain prefix from the address (if any)
  • adds base chain explorer links to account and saved address

Testing notes

A complete smoke testing of wallet is appreciated

This PR doesn't restrict the user from typing EIP-3770 address in the address inputs (send flow and saved address flow) as we supported it in earlier public releases. When user moves to next screen, it just ignores the prefix and takes only the address.

Platforms

  • Android
  • iOS

Steps to test

  • Open Status
  • Navigate to shell share and verify multi chain tab is not shown
  • Navigate to the Wallet tab > tap on any account > open account switcher
  • Verify the chain prefixes are not shown under each accounts and also with options such as copy and receive
  • Navigate to edit account and verify the chain prefix is not shown and can not edit preferred networks
  • Navigate to Saved addresses (Profile > Wallet > Saved addresses)
  • Verify the chain prefixes are not shown and can not edit preferred networks of it
  • Verify the scanner ignores the chain prefix (General scanner and scanner on address inputs)
  • Verify copy and paste functions ignores chain prefix in send flow and in add saved address flow

status: ready

@smohamedjavid smohamedjavid self-assigned this Jan 28, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Jan 28, 2025 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 8d7cc13 #1 2025-01-28 18:10:08 ~2 min tests 📄log
✔️ 8d7cc13 #1 2025-01-28 18:14:40 ~7 min android-e2e 🤖apk 📲
✔️ 8d7cc13 #1 2025-01-28 18:14:50 ~7 min android 🤖apk 📲
✔️ 8d7cc13 #1 2025-01-28 18:18:02 ~10 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 1c9deb2 #2 2025-01-28 20:43:21 ~3 min tests 📄log
✔️ 1c9deb2 #2 2025-01-28 20:46:57 ~6 min android-e2e 🤖apk 📲
✔️ 1c9deb2 #2 2025-01-28 20:47:17 ~7 min android 🤖apk 📲
✔️ 1c9deb2 #2 2025-01-28 20:49:57 ~9 min ios 📱ipa 📲
✔️ 875478b #3 2025-01-28 20:59:28 ~4 min tests 📄log
✔️ 875478b #3 2025-01-28 21:01:44 ~6 min android 🤖apk 📲
✔️ 875478b #3 2025-01-28 21:02:26 ~7 min android-e2e 🤖apk 📲
✔️ 875478b #3 2025-01-28 21:04:21 ~9 min ios 📱ipa 📲

@smohamedjavid smohamedjavid force-pushed the feature/simplify-wallet-address branch from 8d7cc13 to 1c9deb2 Compare January 28, 2025 20:40
@smohamedjavid smohamedjavid force-pushed the feature/simplify-wallet-address branch from 1c9deb2 to 875478b Compare January 28, 2025 20:54
@smohamedjavid smohamedjavid marked this pull request as ready for review January 28, 2025 21:04
@shivekkhurana shivekkhurana added wallet-core Issues for mobile wallet team and removed wallet-core Issues for mobile wallet team labels Jan 29, 2025
@status-im-auto
Copy link
Member

75% of end-end tests have passed

Total executed tests: 8
Failed tests: 2
Expected to fail tests: 0
Passed tests: 6
Not executed tests: 2

IDs of not executed tests: 741554,741555 

IDs of failed tests: 703133,740490

Not executed tests (2)

Click to expand
  • Rerun not executed tests

    • Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestWalletOneDevice:

    1. test_wallet_balance_mainnet, id: 740490

    Device 1: Find `Button` by `accessibility id`: `network-dropdown`
    Device 1: Tap on found: Button 

    critical/test_wallet.py:263: in test_wallet_balance_mainnet
    self.errors.verify_no_errors()
base_test_case.py:179: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Device 1: For the Ether the wrong value 0.0062 is shown, expected 0.0052 in total
E    Device 1: For the Status the wrong value 13.0 is shown, expected 10.0 in total
E    Device 1: For the Ether the wrong value 0.0011 is shown, expected 0.0001 on Optimism
E    Device 1: For the Status the wrong value 3.0 is shown, expected 0 on Optimism



    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133

    Device 1: Tap on found: Button
    # STEP: Check that removed user is not shown in the list anymore

    critical/chats/test_public_chat_browsing.py:246: in test_restore_multiaccount_with_waku_backup_remove_profile_switch
    self.errors.verify_no_errors()
base_test_case.py:179: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Device 1: zQ3...dWXh5 was not restored as a contact from waku backup!
E    Device 1: zQ3...Vacac was not restored as a contact from waku backup!
E    Device 1: admin_open was not restored from waku-backup!!
E    Device 1: member_open was not restored from waku-backup!!
E    Device 1: admin_closed was not restored from waku-backup!!
E    Device 1: member_closed was not restored from waku-backup!!



    Device sessions

    Passed tests (6)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    briansztamfater
    briansztamfater reviewed Jan 30, 2025
    View reviewed changes
    src/utils/address.cljs
    @@ -6,7 +6,8 @@


    (def hex-prefix "0x")
    ;; EIP-3770 is a format used by Status and described here: https://eips.ethereum.org/EIPS/eip-3770
    ;; EIP-3770 is a format used by Status until v2.32 and described here:
    ;; https://eips.ethereum.org/EIPS/eip-3770
    (def regx-eip-3770-address #"^(?:(?:eth:|arb1:|oeth:)(?=:|))*0x[0-9a-fA-F]{40}$")
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Given that we are removing support for these type of addresses, could we remove this regex?

    briansztamfater
    briansztamfater approved these changes Jan 30, 2025
    View reviewed changes
    Copy link
    Member

    @briansztamfater briansztamfater left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM! I just left a non-blocking question, but I'm happy we're getting rid of these types of addresses 🎉

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @briansztamfater briansztamfater briansztamfater approved these changes

    @alwx alwx Awaiting requested review from alwx

    @shivekkhurana shivekkhurana Awaiting requested review from shivekkhurana

    @vkjr vkjr Awaiting requested review from vkjr

    @clauxx clauxx Awaiting requested review from clauxx

    @mohsen-ghafouri mohsen-ghafouri Awaiting requested review from mohsen-ghafouri

    Assignees

    @smohamedjavid smohamedjavid

    Labels
    request-manual-qa wallet-core Issues for mobile wallet team
    Projects
    Pipeline for QA
    Status: REVIEW
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    🧾 Simplify Wallet Address Management by Removing Network Prefixes
    5 participants
    @smohamedjavid @status-im-auto @briansztamfater @shivekkhurana @VolodLytvynenko