Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] feat(wallet): simplify send and bridge flow ux #21595

Draft
wants to merge 15 commits into
base: develop
Choose a base branch
from
Draft

[WIP] feat(wallet): simplify send and bridge flow ux #21595

wants to merge 15 commits into from

Conversation

briansztamfater
Copy link
Member

@briansztamfater briansztamfater commented Nov 6, 2024 •
edited
Loading

fixes #21663

Summary

[WIP] Simplify send and bridge flow ux

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • wallet / transactions

Steps to test

  • Open Status
  • Step 3, etc.

status: wip

@briansztamfater briansztamfater self-assigned this Nov 6, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Nov 6, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (72)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 27d0142 #1 2024-11-06 20:19:14 ~2 min ios 📄log
❌ 27d0142 #1 2024-11-06 20:19:29 ~3 min tests 📄log
✔️ 27d0142 #1 2024-11-06 20:25:19 ~9 min android-e2e 🤖apk 📲
✔️ 27d0142 #1 2024-11-06 20:25:55 ~9 min android 🤖apk 📲
❌ 5cca58b #2 2024-11-07 16:01:08 ~2 min ios 📄log
❌ 5cca58b #2 2024-11-07 16:01:29 ~2 min tests 📄log
✔️ 5cca58b #2 2024-11-07 16:07:21 ~8 min android-e2e 🤖apk 📲
✔️ 5cca58b #2 2024-11-07 16:07:49 ~9 min android 🤖apk 📲
❌ f0288ad #3 2024-11-09 18:44:26 ~2 min ios 📄log
❌ f0288ad #3 2024-11-09 18:44:40 ~2 min tests 📄log
✔️ f0288ad #3 2024-11-09 18:49:25 ~7 min android-e2e 🤖apk 📲
✔️ f0288ad #3 2024-11-09 18:49:46 ~7 min android 🤖apk 📲
❌ 0f77203 #4 2024-11-13 01:43:55 ~2 min tests 📄log
✔️ 0f77203 #4 2024-11-13 01:48:23 ~6 min android-e2e 🤖apk 📲
✔️ 0f77203 #4 2024-11-13 01:49:09 ~7 min android 🤖apk 📲
❌ 7d9f2c8 #5 2024-11-13 01:52:18 ~2 min tests 📄log
✔️ 7d9f2c8 #5 2024-11-13 01:58:15 ~8 min android-e2e 🤖apk 📲
✔️ 7d9f2c8 #5 2024-11-13 01:58:30 ~8 min ios 📱ipa 📲
✔️ 7d9f2c8 #5 2024-11-13 01:58:44 ~9 min android 🤖apk 📲
❌ 39a575e #6 2024-11-20 16:04:55 ~3 min tests 📄log
✔️ 39a575e #6 2024-11-20 16:10:48 ~9 min android-e2e 🤖apk 📲
✔️ 39a575e #6 2024-11-20 16:10:58 ~9 min android 🤖apk 📲
✔️ 39a575e #6 2024-11-20 16:13:44 ~12 min ios 📱ipa 📲
❌ 3205675 #7 2024-11-21 17:07:12 ~2 min tests 📄log
✔️ 3205675 #7 2024-11-21 17:11:27 ~6 min android-e2e 🤖apk 📲
✔️ 3205675 #7 2024-11-21 17:12:37 ~8 min android 🤖apk 📲
✔️ 3205675 #7 2024-11-21 17:13:43 ~9 min ios 📱ipa 📲
❌ 50f9434 #8 2024-11-21 17:37:02 ~2 min tests 📄log
❌ 50f9434 #8 2024-11-21 17:40:11 ~5 min ios 📄log
✔️ 50f9434 #8 2024-11-21 17:42:20 ~7 min android-e2e 🤖apk 📲
✔️ 50f9434 #8 2024-11-21 17:42:56 ~8 min android 🤖apk 📲
❌ da4ef34 #9 2024-11-21 18:04:17 ~2 min tests 📄log
✔️ da4ef34 #9 2024-11-21 18:08:43 ~7 min android-e2e 🤖apk 📲
✔️ da4ef34 #9 2024-11-21 18:09:56 ~8 min android 🤖apk 📲
✔️ da4ef34 #9 2024-11-21 18:11:21 ~9 min ios 📱ipa 📲
❌ 02a4e71 #10 2024-11-22 18:10:05 ~2 min tests 📄log
❌ 0410a4f #11 2024-11-22 18:15:25 ~3 min tests 📄log
✔️ 0410a4f #11 2024-11-22 18:20:29 ~8 min android-e2e 🤖apk 📲
✔️ 0410a4f #11 2024-11-22 18:20:58 ~8 min android 🤖apk 📲
✔️ 0410a4f #11 2024-11-22 18:21:33 ~9 min ios 📱ipa 📲
❌ f2bdcfb #12 2024-11-24 00:39:21 ~3 min tests 📄log
✔️ f2bdcfb #12 2024-11-24 00:44:35 ~8 min android-e2e 🤖apk 📲
✔️ f2bdcfb #12 2024-11-24 00:45:09 ~8 min ios 📱ipa 📲
✔️ f2bdcfb #12 2024-11-24 00:45:20 ~9 min android 🤖apk 📲
❌ 9e33c63 #13 2024-11-25 00:30:22 ~3 min tests 📄log
✔️ 9e33c63 #13 2024-11-25 00:35:48 ~8 min android-e2e 🤖apk 📲
✔️ 9e33c63 #13 2024-11-25 00:36:05 ~8 min ios 📱ipa 📲
✔️ 9e33c63 #13 2024-11-25 00:36:23 ~9 min android 🤖apk 📲
❌ 4ca70b9 #14 2024-11-25 02:50:56 ~3 min tests 📄log
✔️ 4ca70b9 #14 2024-11-25 02:56:09 ~8 min android-e2e 🤖apk 📲
✔️ 4ca70b9 #14 2024-11-25 02:56:35 ~8 min ios 📱ipa 📲
✔️ 4ca70b9 #14 2024-11-25 02:56:57 ~9 min android 🤖apk 📲
❌ 2a47244 #16 2024-11-25 21:15:49 ~2 min tests 📄log
✔️ 2a47244 #16 2024-11-25 21:21:46 ~8 min ios 📱ipa 📲
✔️ 2a47244 #16 2024-11-25 21:21:57 ~8 min android-e2e 🤖apk 📲
✔️ 2a47244 #16 2024-11-25 21:23:35 ~10 min android 🤖apk 📲
❌ d16b21d #17 2024-11-25 21:42:35 ~2 min tests 📄log
✔️ d16b21d #17 2024-11-25 21:48:18 ~8 min android-e2e 🤖apk 📲
✔️ d16b21d #17 2024-11-25 21:48:29 ~8 min ios 📱ipa 📲
✔️ d16b21d #17 2024-11-25 21:48:52 ~9 min android 🤖apk 📲
❌ 2c6aab7 #18 2024-11-26 17:40:19 ~2 min tests 📄log
✔️ 2c6aab7 #18 2024-11-26 17:46:03 ~8 min android-e2e 🤖apk 📲
✔️ 2c6aab7 #18 2024-11-26 17:46:23 ~8 min ios 📱ipa 📲
✔️ 2c6aab7 #18 2024-11-26 17:46:37 ~9 min android 🤖apk 📲
❌ d63240f #19 2024-11-26 17:52:02 ~2 min tests 📄log
✔️ d63240f #19 2024-11-26 17:58:01 ~8 min android-e2e 🤖apk 📲
✔️ d63240f #19 2024-11-26 17:58:08 ~8 min ios 📱ipa 📲
✔️ d63240f #19 2024-11-26 17:58:28 ~9 min android 🤖apk 📲
❌ 7914b4f #20 2024-11-26 18:42:11 ~2 min tests 📄log
✔️ 7914b4f #20 2024-11-26 18:47:58 ~8 min android-e2e 🤖apk 📲
✔️ 7914b4f #20 2024-11-26 18:48:28 ~9 min android 🤖apk 📲
✔️ 7914b4f #20 2024-11-26 18:49:20 ~9 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ ffb8073 #21 2024-11-26 20:05:10 ~2 min tests 📄log
✔️ ffb8073 #21 2024-11-26 20:10:20 ~8 min android-e2e 🤖apk 📲
✔️ ffb8073 #21 2024-11-26 20:10:52 ~8 min android 🤖apk 📲
✔️ ffb8073 #21 2024-11-26 20:11:00 ~8 min ios 📱ipa 📲
❌ a853c7f #23 2024-11-27 23:54:03 ~3 min tests 📄log
✔️ a853c7f #23 2024-11-27 23:58:42 ~7 min android-e2e 🤖apk 📲
✔️ a853c7f #23 2024-11-27 23:59:12 ~8 min android 🤖apk 📲
✔️ a853c7f #23 2024-11-27 23:59:42 ~8 min ios 📱ipa 📲

@briansztamfater briansztamfater force-pushed the feat/simplify-send-flow branch 2 times, most recently from 0f77203 to 7d9f2c8 Compare November 13, 2024 01:49
@briansztamfater briansztamfater force-pushed the feat/simplify-send-flow branch 3 times, most recently from 50f9434 to da4ef34 Compare November 21, 2024 18:01
@briansztamfater briansztamfater added this to the 2.33.0 milestone Nov 21, 2024
@briansztamfater briansztamfater changed the title [WIP] feat(wallet): simplify send flow ux [WIP] feat(wallet): simplify send and bridge flow ux Nov 25, 2024
@briansztamfater briansztamfater force-pushed the feat/simplify-send-flow branch 3 times, most recently from ffb8073 to 9a6a353 Compare November 27, 2024 23:50
@briansztamfater
feat(wallet): simplify send flow ux
a897895 
Signed-off-by: Brian Sztamfater <[email protected]>
@briansztamfater
progress on getsuggestedroutes cleanup
f431ff1
@briansztamfater
remove unnecessary subs and functions
f7590e3
@briansztamfater
fix crash and adapt loading state
53bee2e 
Signed-off-by: Brian Sztamfater <[email protected]>
@briansztamfater
fix no routes found state
c0334ce 
Signed-off-by: Brian Sztamfater <[email protected]>
@briansztamfater
progress on bridge refactor
3af8b46
@briansztamfater
fix start from general wallet screen
87f32e8
@briansztamfater
fix flows when starting from account page
bc75a5a
@briansztamfater
disable selected network on select network to receive on bridge flow,…
2867438 
… and other minor fixes
@briansztamfater
fix bridge loading state
0151764
@briansztamfater
reintroduce bonder fees informational bottom sheet
77b9c04
@briansztamfater
fix collectibles get routes
99c3af9
@briansztamfater
fix (collectibles): when sending from general wallet screen, set firs…
204432d 
…t owner account
@briansztamfater
fix bug with prices introduced on rebase conflict
e678588
@briansztamfater
fix: do not show from page when token is owned from one account and t…
a853c7f 
…rying to send/bridge from main page immediatelly after logging in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivekkhurana shivekkhurana Awaiting requested review from shivekkhurana

At least 1 approving review is required to merge this pull request.

Assignees

@briansztamfater briansztamfater

Labels
None yet
Projects
Pipeline for QA
Status: CONTRIBUTOR
Milestone
2.33.0
Development

Successfully merging this pull request may close these issues.

[Send / Bridge] Remove multichain support and simplify network selection process
2 participants
@briansztamfater @status-im-auto