Use the make question option to avoid rebuild on macOS #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was already the earlier strange ` before the "unity.a' is up to date message on macOS. Turns out it might still not work on macOS because of certain verbosity levels. So use the question option instead of dry-run + grep as the latter is more brittle, and the former is intended for this purpose.
bhartnett
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was already the earlier strange ` before the "unity.a' is up to date message on macOS, fixed by #65
Turns out it might still not work on macOS because of certain verbosity levels.
In nimbus-eth2 a rebuild would still always occur, except when you would do
make rocksdb V=1We could add the
-dflag in the rocksdb build scripts, but that adds a lot of other debug output.So use the question option instead of dry-run + grep as the latter is more brittle, and the former is intended for this purpose.