Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section Defaults TAXONOMIES not save any data #331

Open
yuliia-bondareva-corefy opened this issue May 15, 2024 · 1 comment
Open

Section Defaults TAXONOMIES not save any data #331

yuliia-bondareva-corefy opened this issue May 15, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@yuliia-bondareva-corefy

I create new Taxonomy - test.
I desable seo on Section Defaults page
image

when I reloading page SEO enabled
image

In table taxonomies nothing changed after disabling SEO, except the update date
test,test,"[""en""]","{""layout"": null, ""template"": null, ""revisions"": false, ""term_template"": null, ""preview_targets"": [{""label"": ""Term"", ""format"": ""{permalink}"", ""refresh"": true}]}",2024-05-15 10:05:51,2024-05-15 10:11:56

I disabled SEO for the collection, everything works correctly

Environment
Application Name: PayAtlas
Laravel Version: 11.7.0
PHP Version: 8.3.6
Composer Version: 2.2.6
Environment: local
Debug Mode: ENABLED
URL: payatlas.local
Maintenance Mode: OFF

Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: CACHED

Drivers
Broadcasting: pusher
Cache: statamic
Database: pgsql
Logs: stack / daily, database
Mail: smtp
Queue: sync
Session: database

Statamic
Addons: 4
Sites: 1
Stache Watcher: Enabled
Static Caching: Disabled
Version: 5.1.0 PRO

Statamic Addons
osayaweventures/share-links: 1.0.1
statamic/collaboration: 1.0.0
statamic/eloquent-driver: 4.0.0
statamic/seo-pro: 6.0.2

Statamic Eloquent Driver
Asset Containers: eloquent
Assets: eloquent
Blueprints: eloquent
Collection Trees: eloquent
Collections: eloquent
Entries: eloquent
Forms: eloquent
Global Sets: eloquent
Global Variables: eloquent
Navigation Trees: eloquent
Navigations: eloquent
Revisions: eloquent
Taxonomies: eloquent
Terms: eloquent

@yuliia-bondareva-corefy
Copy link
Author

@duncanmcclean I found how to fix saving SEO parameters in taxonomies
In class Statamic\Eloquent\Taxonomies\Taxonomy
in public static function fromModel you need add ->cascade($model->settings['inject'] ?? []) and
in public static function makeModelFromContract add 'inject' => $source->cascade,

Uploading Screencast from 21.05.24 12:18:06.webm…

image

@duncanmcclean duncanmcclean added the bug Something isn't working label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants