Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package updateEntryUris not compatible with Statche's implementation on composer require #1

Open
benfurfie opened this issue Apr 20, 2023 · 0 comments

Comments

@benfurfie
Copy link

benfurfie commented Apr 20, 2023

Describe what the issue is
The package can not be installed when you run the command composer require statamic/eloquent-entries-example.

What should be happening
The package should install as expected when the command is run.

What is happening
A fatal error is occurring: Declaration of Statamic\Eloquent\Entries\CollectionRepository::updateEntryUris($collection) must be compatible with Statamic\Stache\Repositories\CollectionRepository::updateEntryUris(Statamic\Contracts\Entries\Collection $collection, $ids = null)

Steps to replicate

  1. Follow instructions as per the repo.
  2. Run composer require statamic/eloquent-entries-example.
  3. Observe error.

Any other comments
PR to resolve it: #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant