Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto - JSON transcoder #255

Closed
git-torrent opened this issue Nov 16, 2023 · 2 comments
Closed

Proto - JSON transcoder #255

git-torrent opened this issue Nov 16, 2023 · 2 comments

Comments

@git-torrent
Copy link

git-torrent commented Nov 16, 2023

Hello, on Kong we have long open PR that adds the functionality of proto - json transcoder. I was advised it might save some time if that transcoder would be part of lua-protobuf package.

Is there any possibility to add it to this project? What are requirements? The functionality is concentrated into one file https://github.com/Kong/kong/pull/8297/files#diff-3a78d93fbe0ba99669d5d760d6f3cf5c536dd93deab5b499f8528d3c0eaacf29 (to simulate google's solutions - go, c++ or C#).

I am not a C coder, maybe a Lua one, so my contributions are limited. The code is working and tested. It might be slower than your standard and definitely can benefit from some features of pb.c. Of course, I cannot expect anyone to add these features for me.

Thank you for answer

All the best.

@starwing
Copy link
Owner

You could add jsonproto.lua to lua-protons repo here, but there some issues. That module depends on date and cjson module which is not used by lua-protobuf. So maybe it's better to leave it as a standalone module that depends on lua-proyobuf?

@git-torrent
Copy link
Author

I am not thinking of standalone module with dependency. Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants