Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FibonacciAirGenerator test. #717

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

alonh5
Copy link
Contributor

@alonh5 alonh5 commented Jul 9, 2024

This change is Reviewable

Copy link
Contributor Author

alonh5 commented Jul 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on Graphite Graphite

@alonh5 alonh5 requested a review from ohad-starkware July 9, 2024 12:00
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.52%. Comparing base (673e6cc) to head (cfed49b).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #717   +/-   ##
=======================================
  Coverage   90.52%   90.52%           
=======================================
  Files          76       76           
  Lines       10165    10165           
  Branches    10165    10165           
=======================================
  Hits         9202     9202           
  Misses        881      881           
  Partials       82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved

Copy link
Collaborator

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alonh5)


crates/prover/src/examples/fibonacci/mod.rs line 259 at r1 (raw file):

        let fib = Fibonacci::new(FIB_LOG_SIZE, CLAIM);
        fib.verify(proof).unwrap();

consider

Suggestion:

        let channel =
            &mut Blake2sChannel::new(Blake2sHasher::hash(BaseField::into_slice(&[CLAIM])));
        let fib_air = Fibonacci::new(FIB_LOG_SIZE, CLAIM).air;
        verify(proof, &fib_air, channel).unwrap();

@alonh5 alonh5 force-pushed the 07-09-fix_fibonacciairgenerator_test branch from ca2cc49 to cfed49b Compare July 10, 2024 08:47
Copy link
Contributor Author

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware)


crates/prover/src/examples/fibonacci/mod.rs line 259 at r1 (raw file):

Previously, ohad-starkware (Ohad) wrote…

consider

Done.

Copy link
Collaborator

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

@alonh5 alonh5 merged commit 80c03c9 into dev Jul 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants