-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FibonacciAirGenerator test. #717
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #717 +/- ##
=======================================
Coverage 90.52% 90.52%
=======================================
Files 76 76
Lines 10165 10165
Branches 10165 10165
=======================================
Hits 9202 9202
Misses 881 881
Partials 82 82 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alonh5)
crates/prover/src/examples/fibonacci/mod.rs
line 259 at r1 (raw file):
let fib = Fibonacci::new(FIB_LOG_SIZE, CLAIM); fib.verify(proof).unwrap();
consider
Suggestion:
let channel =
&mut Blake2sChannel::new(Blake2sHasher::hash(BaseField::into_slice(&[CLAIM])));
let fib_air = Fibonacci::new(FIB_LOG_SIZE, CLAIM).air;
verify(proof, &fib_air, channel).unwrap();
ca2cc49
to
cfed49b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware)
crates/prover/src/examples/fibonacci/mod.rs
line 259 at r1 (raw file):
Previously, ohad-starkware (Ohad) wrote…
consider
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)
This change is