Fix previous_bit_reversed_circle_domain_index.

[alonh5]

This change is 

[alonh5]

• Fix previous_bit_reversed_circle_domain_index. #709 👈
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (e167c42) to head (f975168).
Report is 4 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #709      +/-   ##
==========================================
+ Coverage   90.26%   90.32%   +0.06%     
==========================================
  Files          75       75              
  Lines        9944    10203     +259     
  Branches     9944    10203     +259     
==========================================
+ Hits         8976     9216     +240     
- Misses        889      903      +14     
- Partials       79       84       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[spapinistarkware]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

[shaharsamocha7]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)

---

crates/prover/src/core/utils.rs line 204 at r1 (raw file):

    #[test]
    fn test_previous_bit_reversed_circle_domain_index() {

Fix test to use eval_log_size > domain_log_size - 1
so we can see that this fix worked

Code quote:

    #[test]
    fn test_previous_bit_reversed_circle_domain_index() {

[alonh5]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)

---

crates/prover/src/core/utils.rs line 204 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Fix test to use eval_log_size > domain_log_size - 1
so we can see that this fix worked

I did, that's the addition at the end of the test.

[alonh5]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7 and @spapinistarkware)

---

crates/prover/src/core/utils.rs line 204 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

I did, that's the addition at the end of the test.

Done.

[shaharsamocha7]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)