-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blockifier): update cairo native to 0.2.2-alpha.0 #2076
Conversation
Artifacts upload triggered. View details here |
3a76e6d
to
d0f9467
Compare
Artifacts upload triggered. View details here |
d0f9467
to
04985b0
Compare
Artifacts upload triggered. View details here |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2076 +/- ##
===========================================
+ Coverage 40.10% 77.30% +37.19%
===========================================
Files 26 384 +358
Lines 1895 40343 +38448
Branches 1895 40343 +38448
===========================================
+ Hits 760 31187 +30427
- Misses 1100 6864 +5764
- Partials 35 2292 +2257 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
04985b0
to
55b4849
Compare
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 7 files at r1, 2 of 2 files at r2, 2 of 2 files at r3, 8 of 8 files at r4, all commit messages.
Reviewable status: 16 of 18 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, 1 of 2 files at r2, 1 of 2 files at r3, 8 of 8 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @rodrigo-pino)
crates/blockifier/src/execution/native/entry_point_execution.rs
line 25 at r1 (raw file):
context: &mut EntryPointExecutionContext, ) -> EntryPointExecutionResult<CallInfo> { let function_selector = call.entry_point_selector.0;
Please go through .get_entry_point()
since it returns an error if the entrypoint is not found.
You can change the return type of this function.
Please add a TODO to test entrypoint-not-found in native.
Code quote:
let function_selector = call.entry_point_selector.0;
crates/blockifier/src/execution/native/entry_point_execution.rs
line 34 at r1 (raw file):
&syscall_handler.call.calldata.0.clone(), Some(syscall_handler.call.initial_gas.into()), // Todo(rodrigo): What should be the builtin costs?
Same as in here:
let builtin_price_array = [ |
Code quote:
// Todo(rodrigo): What should be the builtin costs?
Artifacts upload triggered. View details here |
Benchmark movements: full_committer_flow performance improved 😺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 16 of 19 files reviewed, 3 unresolved discussions (waiting on @meship-starkware and @rodrigo-pino)
crates/blockifier/src/execution/native/contract_class.rs
line 20 at r5 (raw file):
impl NativeContractClassV1 { pub(crate) fn constructor_selector(&self) -> Option<EntryPointSelector> { self.casm.entry_points_by_type.constructor.first().map(|ep| ep.selector)
Suggestion:
self.casm.constructor_selector()
a16a620
to
4b1825a
Compare
Artifacts upload triggered. View details here |
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 18 files at r6, 2 of 2 files at r8, all commit messages.
Reviewable status: 5 of 21 files reviewed, 3 unresolved discussions (waiting on @meship-starkware and @rodrigo-pino)
4b1825a
to
6bca1e2
Compare
Artifacts upload triggered. View details here |
Benchmark movements: full_committer_flow performance improved 😺 |
6bca1e2
to
82ad9e7
Compare
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 21 files reviewed, 3 unresolved discussions (waiting on @meship-starkware and @Yoni-Starkware)
crates/blockifier/src/execution/native/entry_point_execution.rs
line 25 at r1 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Please go through
.get_entry_point()
since it returns an error if the entrypoint is not found.
You can change the return type of this function.Please add a TODO to test entrypoint-not-found in native.
Done
crates/blockifier/src/execution/native/entry_point_execution.rs
line 34 at r1 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Same as in here:
let builtin_price_array = [
Done.
crates/blockifier/src/execution/native/contract_class.rs
line 20 at r5 (raw file):
impl NativeContractClassV1 { pub(crate) fn constructor_selector(&self) -> Option<EntryPointSelector> { self.casm.entry_points_by_type.constructor.first().map(|ep| ep.selector)
constructor_selector
is a private class, should I make it public for this instance?
82ad9e7
to
e4124c6
Compare
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 18 files at r6, 1 of 2 files at r7, 1 of 14 files at r10, 3 of 13 files at r13, 2 of 2 files at r14, 10 of 10 files at r15, all commit messages.
Reviewable status: 20 of 21 files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @rodrigo-pino)
crates/blockifier/src/execution/native/contract_class.rs
line 20 at r5 (raw file):
Previously, rodrigo-pino (Rodrigo) wrote…
constructor_selector
is a private class, should I make it public for this instance?
Yes
e4124c6
to
0607717
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 20 of 21 files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @Yoni-Starkware)
crates/blockifier/src/execution/native/contract_class.rs
line 20 at r5 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Yes
Done.
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 14 files at r16.
Reviewable status: 9 of 22 files reviewed, all discussions resolved (waiting on @meship-starkware)
refactor(blockifier): modify entry point logic from native runnable class refactor(blockifier): apply general improvements refactor(blockifier): make casm constructor public
0607717
to
8a48ebf
Compare
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 14 files at r16, 2 of 2 files at r17, 9 of 10 files at r18, all commit messages.
Reviewable status: 20 of 22 files reviewed, all discussions resolved (waiting on @meship-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 18 files at r6, 1 of 10 files at r18.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)
No description provided.