Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(network): broadcast stress test #2025

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

feat(network): broadcast stress test #2025

wants to merge 40 commits into from
+487 −9

Conversation

eitanm-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@eitanm-starkware eitanm-starkware force-pushed the eitan/broadcast_stress_test branch from 69c6105 to 8fab583 Compare November 13, 2024 14:41
@eitanm-starkware eitanm-starkware force-pushed the eitan/broadcast_stress_test branch from 8fab583 to 9365978 Compare November 13, 2024 14:59
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@eitanm-starkware eitanm-starkware force-pushed the eitan/broadcast_stress_test branch from ad0ec18 to a568a60 Compare November 13, 2024 15:18
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0.56818% with 175 lines in your changes missing coverage. Please review.

Project coverage is 76.89%. Comparing base (e3165c4) to head (aa5bdd3).
Report is 789 commits behind head on main.

Files with missing lines Patch % Lines
...apyrus_network/src/bin/network_stress_test/main.rs 0.00% 83 Missing ⚠️
...pyrus_network/src/bin/network_stress_test/utils.rs 0.00% 83 Missing ⚠️
..._network/src/bin/network_stress_test/converters.rs 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2025       +/-   ##
===========================================
+ Coverage   40.10%   76.89%   +36.79%     
===========================================
  Files          26      393      +367     
  Lines        1895    42638    +40743     
  Branches     1895    42638    +40743     
===========================================
+ Hits          760    32788    +32028     
- Misses       1100     7558     +6458     
- Partials       35     2292     +2257

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

graphite-app[bot]
graphite-app bot reviewed Nov 14, 2024
View reviewed changes
crates/papyrus_network/src/bin/network_stress_test/converters.rs
Comment on lines 36 to 38
let vec_size = value.len();
let payload_size = vec_size - 12;
let payload_size = vec_size - METADATA_SIZE;
let id_and_time = value.split_off(payload_size);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message parsing code should validate that value.len() >= METADATA_SIZE before attempting to split the message. This prevents panics from malformed messages. Consider adding:

if value.len() < METADATA_SIZE {
    return Err(NetworkError::InvalidMessageFormat);
}

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.502 ms 34.707 ms 34.978 ms]
change: [-4.1773% -2.5308% -1.0323%] (p = 0.00 < 0.05)
Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
2 (2.00%) high mild
9 (9.00%) high severe

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

Artifacts upload workflows:

@eitanm-starkware
chore(network): update peer addr
97e4ca4
@eitanm-starkware
fix(network): duration time
c8b99e4
@eitanm-starkware
chore(network): add log
8883521
@eitanm-starkware
chore(network): add log again
305f9b2
@eitanm-starkware
chore(network): new test
95edb8c
@eitanm-starkware
chore(network)another test
dc999d2
@eitanm-starkware
chore(network): new test
5a9f2f4
@eitanm-starkware
chore(network): 1
6b61de4
@eitanm-starkware
chore(network): test again
336812e
@eitanm-starkware
chore(network): test againn
5a6a6b1
@eitanm-starkware
chore(network): test againn 0.5tp
a56dfb8
@eitanm-starkware
chore(network): test 10K messages 50KB size 25000 sleep 40Mps
7bc3a56
@eitanm-starkware
chore(network): update bootstrap
79899c4
@eitanm-starkware
chore(network): test 10K messages 40KB size 20000 sleep 50Mps
671389d
@eitanm-starkware
chore(network): test 10K messages 80KB size 40000 sleep 25Mps
5af2f19
@eitanm-starkware
chore(network): test 10K messages 100KB size 50000 sleep 20Mps
2353243
@eitanm-starkware
chore(network): test 10K messages 200KB size 100000 sleep 10Mps
14f1b36
@eitanm-starkware
chore(network): test 10K messages 400KB size 200000 sleep 5Mps
a32b0ff
@eitanm-starkware
chore(network): test 10K messages 1MB size 500000 sleep 2Mps
ba5a936
@eitanm-starkware
chore(network): test 10K messages 2MB size 1000000 sleep 1Mps
bc1dd44
@eitanm-starkware
chore(network): test 10K messages 2MB size 1000000 sleep 1Mps - fix
c785c1a
@eitanm-starkware
chore(network): test 10K messages 2MB size 1000000 sleep 1Mps - fix1
aa5bdd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eitanm-starkware @reviewable-StarkWare