feat(blockifier): add support for secp256k1 syscall for native

[varex83]

Should go after #1675 , #1813 , #1546 , #1545

Commit history will be changed in the future, so "feat: add support for keccak syscall" will be removed

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.90%. Comparing base (e3165c4) to head (a4b4fe1).
Report is 544 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1940       +/-   ##
===========================================
+ Coverage   40.10%   68.90%   +28.79%     
===========================================
  Files          26      109       +83     
  Lines        1895    13899    +12004     
  Branches     1895    13899    +12004     
===========================================
+ Hits          760     9577     +8817     
- Misses       1100     3913     +2813     
- Partials       35      409      +374     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware and @Yoni-Starkware)

[avi-starkware]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @varex83)

---

crates/blockifier/src/execution/native/syscall_handler.rs line 642 at r2 (raw file):

        Secp256Point::new(x, y)
            .map(|op| op.map(|p| p.into()))
            .map_err(|e| self.handle_error(remaining_gas, e))

Let's be consistent with #1675 .

Suggestion:

        Secp256Point::new(x, y)
            .map(|option| option.map(|p| p.into()))
            .map_err(|err| self.handle_error(remaining_gas, err))

---

crates/blockifier/src/execution/native/syscall_handler.rs line 680 at r2 (raw file):

        Secp256Point::get_point_from_x(x, y_parity)
            .map(|op| op.map(|p| p.into()))
            .map_err(|e| self.handle_error(remaining_gas, e))

Let's be consistent with #1675 .

Suggestion:

        Secp256Point::get_point_from_x(x, y_parity)
            .map(|option| option.map(|p| p.into()))
            .map_err(|err| self.handle_error(remaining_gas, err))

[avi-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @varex83)

[avi-starkware]

Reviewed 2 of 2 files at r4.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @varex83)

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed all commit messages.
Reviewable status: 1 of 81 files reviewed, all discussions resolved (waiting on @avi-starkware and @Yoni-Starkware)

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[Yoni-Starkware]

Reviewed 2 of 2 files at r8, all commit messages.
Reviewable status: 3 of 81 files reviewed, all discussions resolved (waiting on @avi-starkware and @meship-starkware)

[Yoni-Starkware]

Reviewable status: 3 of 81 files reviewed, all discussions resolved (waiting on @avi-starkware and @meship-starkware)

[Yoni-Starkware]

Reviewed 1 of 80 files at r6.
Reviewable status: 4 of 81 files reviewed, all discussions resolved (waiting on @avi-starkware and @meship-starkware)

[Yoni-Starkware]

Reviewed 77 of 80 files at r6.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @varex83)