From b43abaedd552605f2f710e6c07f9673b43efb71a Mon Sep 17 00:00:00 2001 From: Yair <92672946+yair-starkware@users.noreply.github.com> Date: Mon, 11 Nov 2024 11:44:33 +0200 Subject: [PATCH] chore(batcher): remove unused error (#1817) --- crates/batcher/src/batcher.rs | 3 --- crates/batcher/src/proposal_manager.rs | 2 -- crates/batcher_types/src/errors.rs | 4 ---- 3 files changed, 9 deletions(-) diff --git a/crates/batcher/src/batcher.rs b/crates/batcher/src/batcher.rs index d9b05f14ca..ceaa2f2a44 100644 --- a/crates/batcher/src/batcher.rs +++ b/crates/batcher/src/batcher.rs @@ -238,9 +238,6 @@ impl BatcherStorageWriterTrait for papyrus_storage::StorageWriter { impl From for BatcherError { fn from(err: StartHeightError) -> Self { match err { - StartHeightError::AlreadyWorkingOnHeight { active_height, new_height } => { - BatcherError::AlreadyWorkingOnHeight { active_height, new_height } - } StartHeightError::HeightAlreadyPassed { storage_height, requested_height } => { BatcherError::HeightAlreadyPassed { storage_height, requested_height } } diff --git a/crates/batcher/src/proposal_manager.rs b/crates/batcher/src/proposal_manager.rs index 479853b4e4..e4130d226e 100644 --- a/crates/batcher/src/proposal_manager.rs +++ b/crates/batcher/src/proposal_manager.rs @@ -21,8 +21,6 @@ use crate::transaction_provider::ProposeTransactionProvider; #[derive(Debug, Error)] pub enum StartHeightError { - #[error("Can't start new height {new_height} while working on height {active_height}.")] - AlreadyWorkingOnHeight { active_height: BlockNumber, new_height: BlockNumber }, #[error( "Requested height {requested_height} is lower than the current storage height \ {storage_height}." diff --git a/crates/batcher_types/src/errors.rs b/crates/batcher_types/src/errors.rs index b50bfdf3d2..47fc9bcb59 100644 --- a/crates/batcher_types/src/errors.rs +++ b/crates/batcher_types/src/errors.rs @@ -7,10 +7,6 @@ use crate::batcher_types::ProposalId; #[derive(Clone, Debug, Error, PartialEq, Eq, Serialize, Deserialize)] pub enum BatcherError { - #[error( - "Already working on height {active_height}, can't start working on height {new_height}." - )] - AlreadyWorkingOnHeight { active_height: BlockNumber, new_height: BlockNumber }, #[error( "Decision reached for proposal with ID {proposal_id} that does not exist (might still \ being executed)."