diff --git a/crates/papyrus_network/src/streamed_data_protocol/behaviour_test.rs b/crates/papyrus_network/src/streamed_data_protocol/behaviour_test.rs index 5e3f64b099..a4310a962d 100644 --- a/crates/papyrus_network/src/streamed_data_protocol/behaviour_test.rs +++ b/crates/papyrus_network/src/streamed_data_protocol/behaviour_test.rs @@ -99,9 +99,7 @@ async fn create_and_process_outbound_session() { let mut behaviour = Behaviour::::new(SUBSTREAM_TIMEOUT); - // TODO(shahak): Change to BlockHeadersRequest::default() when the bug that forbids sending - // default messages is fixed. - let query = BlockHeadersRequest { ..Default::default() }; + let query = BlockHeadersRequest::default(); let peer_id = PeerId::random(); let outbound_session_id = behaviour.send_query(query.clone(), peer_id); diff --git a/crates/papyrus_network/src/streamed_data_protocol/handler_test.rs b/crates/papyrus_network/src/streamed_data_protocol/handler_test.rs index 69b839104b..2811197fd3 100644 --- a/crates/papyrus_network/src/streamed_data_protocol/handler_test.rs +++ b/crates/papyrus_network/src/streamed_data_protocol/handler_test.rs @@ -193,9 +193,7 @@ async fn process_inbound_session() { ); let (inbound_stream, mut outbound_stream, _) = get_connected_streams().await; - // TODO(shahak): Change to BlockHeadersRequest::default() when the bug that forbids sending - // default messages is fixed. - let query = BlockHeadersRequest { ..Default::default() }; + let query = BlockHeadersRequest::default(); let inbound_session_id = InboundSessionId { value: 1 }; simulate_negotiated_inbound_session_from_swarm( @@ -313,7 +311,7 @@ async fn process_outbound_session() { write_message(data, &mut inbound_stream).await.unwrap(); } - for data in hardcoded_data_vec.clone() { + for data in hardcoded_data_vec { validate_received_data_event(&mut handler, &data, outbound_session_id).await; } diff --git a/docs/CONTRIBUTING.md b/docs/CONTRIBUTING.md index 14077fd041..4a8e2d7f73 100644 --- a/docs/CONTRIBUTING.md +++ b/docs/CONTRIBUTING.md @@ -49,7 +49,7 @@ Then, you will need to install - You'll need Ganache only for the tests of the [papyrus_base_layer](../crates/papyrus_base_layer/) crate. - [Protoc](https://github.com/protocolbuffers/protobuf/releases/tag/v24.3) - You'll need Protoc only for compiling the [papyrus_network](../crates/papyrus_network/) crate. - - required version is: 24.3. + - required version is: 24.3. - the `protoc` execution file should be placed in the `papyrus_network` folder (git is set to automatically ignore it). ### CI