Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation fails without CONFIG_RISCV_NONSTANDARD_CACHE_OPS #116

Open
caseif opened this issue Aug 21, 2023 · 1 comment
Open

Compilation fails without CONFIG_RISCV_NONSTANDARD_CACHE_OPS #116

caseif opened this issue Aug 21, 2023 · 1 comment

Comments

@caseif
Copy link

caseif commented Aug 21, 2023

Compilation of the kernel fails during linking on my system due to an undefined reference in drivers/gpu/drm/starfive/starfive_drm_vpp.c to function sifive_ccache_flush_range, which is implemented in drivers/soc/sifive/sifive_ccache.c. This implementation is guarded by a preprocessor check for the CONFIG_RISCV_NONSTANDARD_CACHE_OPS option, but the call in starfive_drm_vpp.c is not thus causing the undefined reference error.

I'm not super versed in driver/kernel development so I won't speculate on the underlying reasoning for conditional compilation, but I suspect that the call to the function should probably be ifdef-guarded given that its implementation is guarded. Adding a guard or setting the option both result in successful compilation.

@esmil
Copy link
Collaborator

esmil commented Aug 27, 2023

This should be fixed in the latest version of the visionfive branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants