Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for using pathfinder as init omits argument #976

Closed
wpetry opened this issue May 19, 2024 · 1 comment · Fixed by #1011
Closed

Test for using pathfinder as init omits argument #976

wpetry opened this issue May 19, 2024 · 1 comment · Fixed by #1011

Comments

@wpetry
Copy link

wpetry commented May 19, 2024

test_that("Pathfinder method with psis_resample as false works as init", {
mod_logistic <- testing_model("logistic")
utils::capture.output(fit_path_init <- mod_logistic$pathfinder(
seed=1234, data = data_list_logistic, refresh = 0, num_paths = 1))
expect_no_error(test_inits(mod_logistic, fit_path_init, data_list_logistic))
})

This test is identical to the one above it called "Pathfinder works as init", omitting psis_resample = FALSE suggested by the test title.

@jgabry
Copy link
Member

jgabry commented Jul 17, 2024

Thanks for pointing that out! Should be fixed by #1011.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants