Skip to content

Commit

Permalink
Merge pull request #63 from stackitcloud/bugfix/ChartAppVersion
Browse files Browse the repository at this point in the history
fix: Chart appVersion
  • Loading branch information
PatrickKoss authored Dec 5, 2024
2 parents 5442665 + bef6454 commit 00919a1
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Release
on:
push:
tags:
- "*"
- "v*"

permissions: read-all

Expand Down
6 changes: 3 additions & 3 deletions CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
* patrick.koss@mail.schwarz
* patrick.koss@stackit.cloud
* [email protected]
* simon.stier@mail.schwarz
* [email protected]
* simon.stier@stackit.cloud
* [email protected]
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -234,5 +234,5 @@ For those interested in the Helm chart creation mechanics, the process was facil
helm package deploy/stackit
```
To release a new version of the Helm chart, one must meticulously update the version delineation in the
To release a new version of the Helm chart, one must meticulously update the appVersion and (chart)version delineation in the
[Chart.yaml](./deploy/stackit/Chart.yaml). Post this modification, initiate a new release to encompass these changes.
6 changes: 3 additions & 3 deletions deploy/stackit/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
apiVersion: v1
appVersion: "1.0"
description: A Helm chart for Kubernetes
appVersion: "v0.3.1"
description: A Helm chart for stackitcloud/stackit-cert-manager-webhook
name: stackit-cert-manager-webhook
version: 0.3.2
version: 0.3.3
2 changes: 1 addition & 1 deletion deploy/stackit/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ spec:
serviceAccountName: {{ include "stackit-cert-manager-webhook.fullname" . }}
containers:
- name: {{ .Chart.Name }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
args:
- --tls-cert-file=/tls/tls.crt
Expand Down
4 changes: 2 additions & 2 deletions deploy/stackit/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ certManager:
image:
# -- repository of the image.
repository: ghcr.io/stackitcloud/stackit-cert-manager-webhook
# -- tag of the image.
tag: v0.3.1
# Overrides the image tag whose default is {{ .Chart.AppVersion }}
tag: ""
# -- pull policy of the image.
pullPolicy: IfNotPresent

Expand Down

0 comments on commit 00919a1

Please sign in to comment.