Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge C++/Python context #2256

Open
jorisv opened this issue May 29, 2024 · 0 comments
Open

Merge C++/Python context #2256

jorisv opened this issue May 29, 2024 · 0 comments
Labels

Comments

@jorisv
Copy link
Contributor

jorisv commented May 29, 2024

Pinocchio use context file to be build against specific scalar type. There are specific context file for python and C++ build. Both contains some overlapping code and should be merged.
This will allow to avoid code duplication, but also to use explicit template instantiation C++ library to build python bindings.

Context file are used:

  • To construct a python binding for a specific scalar type.
  • To construct explicitly template instantiate C++ Pinocchio function for specific scalar type (pinocchio_default, pinocchio_casadi, pinocchio_cppad, pinocchio_cppadcg).

Both context file all contains some redundant information:

  • Scalar to use
  • Function specialization for custom scalar
  • Typedef of main types with custom scalar
  • Include to manage custom scalar
  • Define to skip some algorithm not supported by a custom scalar type

The only part that should be keep splitted is the python specific part (eigenpy and pinocchio::python specialization).

@jorisv jorisv added the c++ label May 29, 2024
@jorisv jorisv added this to Pinocchio May 29, 2024
@jorisv jorisv moved this to Backlog in Pinocchio May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

1 participant