-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tautological self-reference in schema? #10
Comments
ref: eb3d494 (commit being reverted) discussion: #60 (comment) upstream issue: stac-extensions/template#10
ref: eb3d494 (commit being reverted) discussion: #60 (comment) upstream issue: stac-extensions/template#10
Thanks for keeping us in the loop, sorry for being so unresponsive (day work and so on, you know...). |
I think this can be closed as-is. We've moved to using ospec for unit testing changes to the examples, and those test against the specific schema we're interested in, so we can ensure |
Isn't this self-reference tautological? Basically, if you're validating foo.json against bar.json it's because foo.json referenced bar.json in
stac_extensions
, right? Why validate that it does have that reference? Conversely, why validate a file against a schema it doesn't reference?The only other side effect I can see is that this forces every STAC JSON file to list every extension any of the STAC extensions reference. So if schema
foo
references schemabar
, and schemabar
referencesbaz
, all STAC files which implement schemafoo
need to also listbar
andbaz
instac_extensions
. This seems clunky:stac_extensions
, but also implicitly via each schema which references the other schema.bar
no longer referencesbaz
) and validation errors (bar
now references a new version ofbaz
, and also referencesban
, which referencesbat
, and so on).Based on a PR and follow-up discussion.
Update:
The text was updated successfully, but these errors were encountered: