-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
html-minifier causes React to throw reconciliation errors. #45
Comments
Indeed, concerning the inlined styles, this should be treated here: https://github.com/facebook/react/blob/master/src/renderers/dom/shared/CSSPropertyOperations.js#L172 |
Should I put an issue on React or html-minifier ? Not sure which one will listen 😄 |
I'm doing it right now. I'll reference our issue in FB's repo. |
I've also referenced this issue on html-minifier as it should not alter inline styles when |
I will make a commit where I comment the code responsible of making the minification happen for now. So we can keep on iterating the demo without having bugs. |
From my understanding, this has been fixed in both react and html-minifier. |
The HTML minifier is not aligned with React rendering because it does things such as :
I don't know about other differences between the react rendering and the html-minifier, but we should search for them and make sure it doesn't cause problems in the future.
I guess, the html-minifier should simply not do anything except removing whitespaces between tags.
The text was updated successfully, but these errors were encountered: