Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AudioEncoderFormat #293

Open
ansarmie opened this issue Apr 17, 2024 · 1 comment
Open

Add AudioEncoderFormat #293

ansarmie opened this issue Apr 17, 2024 · 1 comment

Comments

@ansarmie
Copy link

I noticed the MP4 container supports older audio codecs. Like Windows.Media.MediaProperties - MediaEncodingSubtypes.Mp3 Property.

Full list:

MPEG-4 (MP4) | MDN.

It would be nice if there was a possibility to add AudioEncoderFormat options similar to VideoEncoderFormat to expose the audio codec selection to the consumer of the library. And still default to AAC if unused.

Right now it looks like AAC is taken from a constant here:

CommonTypes.h - AUDIO_OPTIONS/AUDIO_ENCODING_FORMAT .

And then used here:

OutputManager.cpp - OutputManager::ConfigureOutputMediaTypes.

@sskodje
Copy link
Owner

sskodje commented Apr 17, 2024

Hi! I never got anything but AAC to work with H264 or HEVC in mp4 container using Media Foundation, which is why it is hardcoded. It is very poorly documented. That's a few years ago now, so if you can make it work, i'm more than happy to add options for it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants