forked from ParadiseSS13/Paradise
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TM] GAS fixes #1757
Open
msw7007
wants to merge
34
commits into
ss220club:master
Choose a base branch
from
msw7007:gbs_fixes_1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[TM] GAS fixes #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request addresses several bug fixes and enhancements, primarily focused on the Serpentid species. It fixes excessive Global Broadcast System (GBS) messages, adjusts Serpentid traits and equipment, and implements other minor improvements. Sequence diagram for Serpentid blade activation and visibilitysequenceDiagram
participant User
participant BladeImplant
participant Kidneys
participant Visibility
User->>BladeImplant: Activate blades
BladeImplant->>BladeImplant: Check if changeling
alt is changeling
BladeImplant->>BladeImplant: Retract changeling weapons
end
BladeImplant->>Visibility: Reset visibility
BladeImplant->>Kidneys: Force off cloak mode
Note over Kidneys: Prevents cloak abuse
Kidneys-->>User: Update visibility state
Class diagram for updated Serpentid organ componentsclassDiagram
class OrganDecay {
-decay_rate
-recover_rate
-death_state_timer
-lt_live
+Initialize(decay_rate, recover_rate)
+process()
}
class SerpentidOrgans {
<<interface>>
}
class Heart {
+icon_state: heart-on
+dead_icon: heart-off
+Initialize()
}
class Kidneys {
+Initialize()
+switch_mode()
}
class Eyes {
+Initialize()
+active: bool
}
class Lungs {
+Initialize()
+active_secretion: bool
}
SerpentidOrgans <|-- Heart
SerpentidOrgans <|-- Kidneys
SerpentidOrgans <|-- Eyes
SerpentidOrgans <|-- Lungs
note for OrganDecay "Modified decay rates for balance"
note for SerpentidOrgans "All organs now have increased decay rates"
State diagram for Serpentid carapace systemstateDiagram-v2
[*] --> Intact: Initial state
Intact --> Stage1Broken: Damage > Threshold1
Stage1Broken --> Stage2Broken: Damage > Threshold2
Stage2Broken --> Stage3Broken: Damage > Threshold3
Stage1Broken --> Intact: Surgery repair
Stage2Broken --> Stage1Broken: Surgery repair
Stage3Broken --> Stage2Broken: Surgery repair
note right of Intact: Pierce immune
note right of Stage1Broken: Reduced armor
note right of Stage2Broken: Severely reduced armor
note right of Stage3Broken: No armor
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
github-actions
bot
added
the
🔧 Фикс
Переписываем ошибку так, чтобы она проявлялась в других обстоятельствах
label
Jan 20, 2025
github-actions
bot
added
💾 Изменение конфига
Ф-ф-фуриор...?
Частичная модульность
Не всегда получается всё впихнуть в модуль, увы.
labels
Jan 21, 2025
github-actions
bot
added
the
🖌️ Спрайты
Вы заработали свою миска-рис и кошко-жена. Партия гордится вами!
label
Jan 22, 2025
…анавливать целостность без слома хитина
ss220app
bot
added
📜 CL невалиден
Этот чейнджлог не пройдет валидацию перед публикацией. Исправить или удалить, если не требуется
and removed
📜 CL валиден
Этот чейнджлог будет успешно опубликован
labels
Jan 23, 2025
ss220app
bot
removed
the
📜 CL невалиден
Этот чейнджлог не пройдет валидацию перед публикацией. Исправить или удалить, если не требуется
label
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Частичная модульность
Не всегда получается всё впихнуть в модуль, увы.
💾 Изменение конфига
Ф-ф-фуриор...?
🖌️ Спрайты
Вы заработали свою миска-рис и кошко-жена. Партия гордится вами!
📜 CL валиден
Этот чейнджлог будет успешно опубликован
Testmerge Required
🔧 Фикс
Переписываем ошибку так, чтобы она проявлялась в других обстоятельствах
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что этот PR делает
Фиксы ГБС которые обнаружились в ходе эксплуатации
Почему это хорошо для игры
Меньше ошибок
Изображения изменений
Тестирование
Локальный сервер
Changelog
🆑
fix: Исправление спама ГБС
fix: Исправление ошибок связанных с генокрадом-ГБС
tweak: Закрытие для ГБС культа
tweak: Операции по восстановлению целостности панциря больше не требуют слома хитина
tweak: Операции по работе с хитином и целостностью панциря были разделены для более понятного обозначения
/:cl: