-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Clothes not showing in vendors roundstart #1754
Conversation
Reviewer's Guide by SourceryThe pull request fixes an issue where certain clothing items, specifically those for junior staff and the metro cop set, were not appearing in department vending machines. This was achieved by ensuring that the parent class's initialization logic is called after the vending machine's product list is populated. Sequence diagram for vending machine initializationsequenceDiagram
participant VM as Vending Machine
participant Parent as Parent Class
Note over VM: Old initialization flow
VM->>Parent: Initialize()
Parent-->>VM: Return
VM->>VM: Add products
Note over VM: New initialization flow
VM->>VM: Add products
VM->>Parent: Initialize()
Parent-->>VM: Return
Class diagram for vending machine hierarchyclassDiagram
class VendingMachine {
+Initialize(mapload)
}
class MediDrobe {
+Initialize(mapload)
+products
}
class SecDrobe {
+Initialize(mapload)
+products
}
class SciDrobe {
+Initialize(mapload)
+products
}
class EngiDrobe {
+Initialize(mapload)
+products
}
VendingMachine <|-- MediDrobe
VendingMachine <|-- SecDrobe
VendingMachine <|-- SciDrobe
VendingMachine <|-- EngiDrobe
note for VendingMachine "Parent initialization must occur after product list modification"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Что стоит отметить: |
Вроде это просто реколор. У одного светятся глаза, у другого нет |
Что этот PR делает
Исправляет отображение одежды младшего персонала, равно как и набора метрокопа, в автоматах одежды департаментов.
Почему это хорошо для игры
Трекер, но ситуация была характерна не только для набора метрокопа, но и для всех вещей младшего персонала.
Тестирование
Скомпилировал локально, проверил отображение в автоматах.
Changelog
🆑 Furgar
fix: Исправлено отображение одежды младшего персонала и набора метрокопа в вендорах отделов.
/:cl:
Summary by Sourcery
Bug Fixes: