Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[s] Illegal NT Instructor #1729

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Conversation

m-dzianishchyts
Copy link
Collaborator

@m-dzianishchyts m-dzianishchyts commented Jan 4, 2025

Что этот PR делает

Чинит флаги джобок, чтобы NCT в префах не совпадал с инженерным стажером. Люди заходят на роль без прав.

Summary by Sourcery

Bug Fixes:

  • Fix job flags to prevent NCT from matching engineering trainee.

Copy link

sourcery-ai bot commented Jan 4, 2025

Reviewer's Guide by Sourcery

This pull request fixes job flags to prevent conflicts between NanoTrasen Corporation (NCT) and engineering interns. It shifts the bitwise flags for JOB_TRAINEE, JOB_CADET, and JOB_PILOT up by one position to accommodate a new flag presumably for instructors within the engineering security job category.

Class diagram showing updated job flag bit positions

classDiagram
    class JobFlags {
        <<enumeration>>
        JOB_INSTRUCTOR: 1<<15
        JOB_TRAINEE: 1<<16
        JOB_CADET: 1<<17
        JOB_PILOT: 1<<18 (commented)
    }
    note for JobFlags "Bit positions shifted up
to prevent NCT/trainee conflicts"
Loading

File-Level Changes

Change Details Files
Shifted job flags to prevent conflicts between NCT and interns.
  • Changed JOB_TRAINEE from (1<<15) to (1<<16).
  • Changed JOB_CADET from (1<<16) to (1<<17).
  • Commented out JOB_PILOT and potentially moved it to (1<<18).
  • Added a comment indicating that engineering security jobs now start with JOB_INSTRUCTOR at (1<<15).
modular_ss220/_defines220/code/job_defines.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the 🔧 Фикс Переписываем ошибку так, чтобы она проявлялась в других обстоятельствах label Jan 4, 2025
@AyIong AyIong merged commit 0ebd7e2 into ss220club:master Jan 4, 2025
15 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 CL невалиден 🔧 Фикс Переписываем ошибку так, чтобы она проявлялась в других обстоятельствах
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants