Skip to content
This repository has been archived by the owner on Feb 26, 2022. It is now read-only.

Proxy should intercept 404s and nicify them #7

Open
PeterJCLaw opened this issue Oct 13, 2019 · 0 comments · May be fixed by #8
Open

Proxy should intercept 404s and nicify them #7

PeterJCLaw opened this issue Oct 13, 2019 · 0 comments · May be fixed by #8

Comments

@PeterJCLaw
Copy link
Member

GitHub pages does support custom 404 pages, however that means that we'd need to implement them in each of our pages repos. It would be nicer if the proxy could handle this for us, at least for the GitHub Pages proxies (other backends might want a different behaviour).

proxy_intercept_errors seems useful here, as does this Stack Overflow post which shows how each location block can have its own error_page handling.

@RealOrangeOne RealOrangeOne linked a pull request Oct 13, 2019 that will close this issue
@PeterJCLaw PeterJCLaw changed the title Proxy should intercept 404s nicify them Proxy should intercept 404s and nicify them Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant