This repository has been archived by the owner on Sep 29, 2020. It is now read-only.
skipping Content-Type check for http responses containing feed data #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontent type, and a fix for feeds containing non-escaped uris... and a couple other tiny changes to require lines (ie: digest/md5 instead of md5)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there... I came across an issue in the app we're building where some feeds aren't sending the correct content-type in the http headers, ie: text/html for an atom feed, etc... I added a very small change here to provide a new, optional arg to update! which specifies whether or not the underlying network operation should do this validation... if there's a different/better way I should have done this, please let me know and if it's not too much work I can maybe re-write them differently... either way, please let me know if you will or will not be able to merge this in - I'd prefer not to have to maintain the atom-tools src in /vendor/gems of our project if I can help it, but ... thanks!