From 71b181efeb5dd1bfc3f1afe8454105c21ac9935a Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Thu, 28 Nov 2024 12:24:07 +0000
Subject: [PATCH 01/42] Initial setup

---
 .github/workflows/slow.yaml | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index 534b293543f..e6055f8038e 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -181,3 +181,20 @@ jobs:
         with:
           name: build-logs-freebsd-${{ matrix.osversion }}
           path: btlayer-*.log
+
+  coverity-scan:
+    runs-on: ubuntu-22.04
+    name: Scan with Coverity
+    steps:
+      - name: Checkout Sources
+        uses: actions/checkout@v4
+
+      - name: Coverity Full Scan
+        uses: synopsys-sig/synopsys-action@v1.13.0
+        with:
+          coverity_url: ${{ vars.COVERITY_URL }}
+          coverity_user: ${{ secrets.COVERITY_USER }}
+          coverity_passphrase: ${{ secrets.COVERITY_PASSPHRASE }}
+          coverity_project_name: ${{ github.event.repository.name }}
+          coverity_stream_name: ${{ github.event.repository.name }}-${{ github.ref_name }}
+          coverity_policy_view: 'Outstanding Issues'

From b923ea21464c8c13c94bda176d6482d5c099a6fb Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Thu, 28 Nov 2024 12:27:26 +0000
Subject: [PATCH 02/42] Disable non-tested jobs

---
 .github/workflows/slow.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index e6055f8038e..fce2dcb3498 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -21,6 +21,7 @@ concurrency:
 
 jobs:
   linux-distros:
+    if: false
 
     strategy:
       matrix:
@@ -82,6 +83,7 @@ jobs:
   macos:
     runs-on: macos-14
     name: macos
+    if: false
 
     steps:
       - name: Install prerequisite MacOS packages
@@ -136,6 +138,7 @@ jobs:
           path: btlayer-*.log
 
   freebsd:
+    if: false
     strategy:
       matrix:
         osversion:

From acaa6f8ec6f43195bf250d41325318621c4e00bc Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Thu, 28 Nov 2024 12:36:25 +0000
Subject: [PATCH 03/42] Try referencing secrets

---
 .github/workflows/slow.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index fce2dcb3498..e5647e340a8 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -188,6 +188,11 @@ jobs:
   coverity-scan:
     runs-on: ubuntu-22.04
     name: Scan with Coverity
+    env:
+        coverity_url: ${{ vars.COVERITY_URL }}
+        coverity_user: ${{ secrets.COVERITY_USER }}
+        coverity_passphrase: ${{ secrets.COVERITY_PASSPHRASE }}
+
     steps:
       - name: Checkout Sources
         uses: actions/checkout@v4

From 0af2c630da20fbd90c20a95fb25bf13d6f9a027a Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Thu, 28 Nov 2024 12:45:00 +0000
Subject: [PATCH 04/42] Actually run the scan, possibly

---
 .github/workflows/slow.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index e5647e340a8..b993b12b34c 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -187,7 +187,7 @@ jobs:
 
   coverity-scan:
     runs-on: ubuntu-22.04
-    name: Scan with Coverity
+    name: Coverity Scan
     env:
         coverity_url: ${{ vars.COVERITY_URL }}
         coverity_user: ${{ secrets.COVERITY_USER }}
@@ -206,3 +206,5 @@ jobs:
           coverity_project_name: ${{ github.event.repository.name }}
           coverity_stream_name: ${{ github.event.repository.name }}-${{ github.ref_name }}
           coverity_policy_view: 'Outstanding Issues'
+          coverity_waitForScan: true
+          coverity_build_command: ./test-builds.sh layer-02-maximus

From 5ddd261a4835e1f175855f290747153074e55b73 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Fri, 6 Dec 2024 17:58:21 +0000
Subject: [PATCH 05/42] Coverity: run scanning manually

---
 .github/workflows/slow.yaml | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index b993b12b34c..01236293bea 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -186,10 +186,13 @@ jobs:
           path: btlayer-*.log
 
   coverity-scan:
-    runs-on: ubuntu-22.04
     name: Coverity Scan
+    runs-on: ubuntu-22.04
+    if: ${{ secrets.COVERITY_USER }} && ${{ secrets.COVERITY_PASSPHRASE }}
+    container:
+      image: squidcache/buildfarm-coverity:stable
+      options: --user 1001 # uid used by worfklow runner
     env:
-        coverity_url: ${{ vars.COVERITY_URL }}
         coverity_user: ${{ secrets.COVERITY_USER }}
         coverity_passphrase: ${{ secrets.COVERITY_PASSPHRASE }}
 
@@ -198,13 +201,11 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Coverity Full Scan
-        uses: synopsys-sig/synopsys-action@v1.13.0
-        with:
-          coverity_url: ${{ vars.COVERITY_URL }}
-          coverity_user: ${{ secrets.COVERITY_USER }}
-          coverity_passphrase: ${{ secrets.COVERITY_PASSPHRASE }}
-          coverity_project_name: ${{ github.event.repository.name }}
-          coverity_stream_name: ${{ github.event.repository.name }}-${{ github.ref_name }}
-          coverity_policy_view: 'Outstanding Issues'
-          coverity_waitForScan: true
-          coverity_build_command: ./test-builds.sh layer-02-maximus
+        run: |
+          cov-build --dir cov-int ./test-builds.sh layer-02-maximus
+          tar cfz cov-int.tar.gz cov-int
+          curl --form project=Squid \
+            --form file=@cov-int.tar.gz \
+            --form token=${coverity_passphrase} \
+            --form email=$${coverity_user} \
+            https://scan.coverity.com/builds
\ No newline at end of file

From 3b41f14439ec1d4165a45823f38125c33acca68a Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Fri, 6 Dec 2024 18:04:04 +0000
Subject: [PATCH 06/42] secrets are not available in if context

---
 .github/workflows/slow.yaml | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index 01236293bea..1949ad6b35b 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -188,13 +188,14 @@ jobs:
   coverity-scan:
     name: Coverity Scan
     runs-on: ubuntu-22.04
-    if: ${{ secrets.COVERITY_USER }} && ${{ secrets.COVERITY_PASSPHRASE }}
+    env:
+      coverity_user: ${{ secrets.COVERITY_USER }}
+      coverity_token: ${{ secrets.COVERITY_TOKEN }}
+
+    if: ${{ env.coverity_user }} && ${{ env.coverity_token }}
     container:
       image: squidcache/buildfarm-coverity:stable
       options: --user 1001 # uid used by worfklow runner
-    env:
-        coverity_user: ${{ secrets.COVERITY_USER }}
-        coverity_passphrase: ${{ secrets.COVERITY_PASSPHRASE }}
 
     steps:
       - name: Checkout Sources

From 0539a778443a4c4bf7aaf5db79060e27e19abdf1 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Fri, 6 Dec 2024 18:16:13 +0000
Subject: [PATCH 07/42] try hoisting env to top level

---
 .github/workflows/slow.yaml | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index 1949ad6b35b..fe21bce236f 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -19,6 +19,10 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
+env:
+  coverity_user: ${{ secrets.COVERITY_USER }}
+  coverity_token: ${{ secrets.COVERITY_TOKEN }}
+
 jobs:
   linux-distros:
     if: false
@@ -188,9 +192,6 @@ jobs:
   coverity-scan:
     name: Coverity Scan
     runs-on: ubuntu-22.04
-    env:
-      coverity_user: ${{ secrets.COVERITY_USER }}
-      coverity_token: ${{ secrets.COVERITY_TOKEN }}
 
     if: ${{ env.coverity_user }} && ${{ env.coverity_token }}
     container:

From 21e5a400337eeaade0926bd028978f7903481184 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Fri, 6 Dec 2024 18:18:25 +0000
Subject: [PATCH 08/42] move if-condition to workflow step

---
 .github/workflows/slow.yaml | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index fe21bce236f..aa2a16df763 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -19,10 +19,6 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
-env:
-  coverity_user: ${{ secrets.COVERITY_USER }}
-  coverity_token: ${{ secrets.COVERITY_TOKEN }}
-
 jobs:
   linux-distros:
     if: false
@@ -192,8 +188,10 @@ jobs:
   coverity-scan:
     name: Coverity Scan
     runs-on: ubuntu-22.04
+    env:
+      coverity_user: ${{ secrets.COVERITY_USER }}
+      coverity_token: ${{ secrets.COVERITY_TOKEN }}
 
-    if: ${{ env.coverity_user }} && ${{ env.coverity_token }}
     container:
       image: squidcache/buildfarm-coverity:stable
       options: --user 1001 # uid used by worfklow runner
@@ -203,6 +201,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Coverity Full Scan
+        if: ${{ env.coverity_user }} && ${{ env.coverity_token }}
         run: |
           cov-build --dir cov-int ./test-builds.sh layer-02-maximus
           tar cfz cov-int.tar.gz cov-int

From 6f91087c9f5ee5e5edb3521e27d4fe22b460e3da Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Fri, 6 Dec 2024 21:06:52 +0000
Subject: [PATCH 09/42] fix syntax

---
 .github/workflows/slow.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index aa2a16df763..c75d88ca84f 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -205,8 +205,9 @@ jobs:
         run: |
           cov-build --dir cov-int ./test-builds.sh layer-02-maximus
           tar cfz cov-int.tar.gz cov-int
+          echo "user: ${coverity_user}"
           curl --form project=Squid \
             --form file=@cov-int.tar.gz \
-            --form token=${coverity_passphrase} \
-            --form email=$${coverity_user} \
+            --form token=${coverity_token} \
+            --form email=${coverity_user} \
             https://scan.coverity.com/builds
\ No newline at end of file

From 76350dcb0a862da9740eaf3a95bb9f0844a3b3ae Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Fri, 6 Dec 2024 21:55:45 +0000
Subject: [PATCH 10/42] explore how to pass secrets

---
 .github/workflows/slow.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index c75d88ca84f..f0555e3ca37 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -203,11 +203,11 @@ jobs:
       - name: Coverity Full Scan
         if: ${{ env.coverity_user }} && ${{ env.coverity_token }}
         run: |
+          echo "user:  ${{ env.coverity_user }}"
           cov-build --dir cov-int ./test-builds.sh layer-02-maximus
           tar cfz cov-int.tar.gz cov-int
-          echo "user: ${coverity_user}"
           curl --form project=Squid \
             --form file=@cov-int.tar.gz \
-            --form token=${coverity_token} \
-            --form email=${coverity_user} \
+            --form token="${{ env.coverity_token }}" \
+            --form email="${{ env.coverity_user }}" \
             https://scan.coverity.com/builds
\ No newline at end of file

From 1439c6c4c775e9d4fef2e3af228993385e4125ec Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Fri, 6 Dec 2024 21:59:56 +0000
Subject: [PATCH 11/42] fix secret name

---
 .github/workflows/slow.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index f0555e3ca37..bb8638998da 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -190,7 +190,7 @@ jobs:
     runs-on: ubuntu-22.04
     env:
       coverity_user: ${{ secrets.COVERITY_USER }}
-      coverity_token: ${{ secrets.COVERITY_TOKEN }}
+      coverity_token: ${{ secrets.COVERITY_PASSPHRASE }}
 
     container:
       image: squidcache/buildfarm-coverity:stable

From 8d5257e8e27db5975152fdd0dcef0331b945adca Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Fri, 6 Dec 2024 22:37:27 +0000
Subject: [PATCH 12/42] output token

---
 .github/workflows/slow.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index bb8638998da..c93efa913f6 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -203,7 +203,8 @@ jobs:
       - name: Coverity Full Scan
         if: ${{ env.coverity_user }} && ${{ env.coverity_token }}
         run: |
-          echo "user:  ${{ env.coverity_user }}"
+          echo "user:  ${coverity_user}, token: ${coverity_token}"
+          exit 0
           cov-build --dir cov-int ./test-builds.sh layer-02-maximus
           tar cfz cov-int.tar.gz cov-int
           curl --form project=Squid \

From a2ce3651ab95977210b9962e9d77f54dc66b5a00 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Fri, 6 Dec 2024 22:40:48 +0000
Subject: [PATCH 13/42] figure out if token are getting passed

---
 .github/workflows/slow.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index c93efa913f6..19ef383d195 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -203,7 +203,9 @@ jobs:
       - name: Coverity Full Scan
         if: ${{ env.coverity_user }} && ${{ env.coverity_token }}
         run: |
-          echo "user:  ${coverity_user}, token: ${coverity_token}"
+          echo "user: ${coverity_user}, token: ${coverity_token}"
+          echo -n "user size: "; echo ${coverity_user} | wc -c
+          echo -n "token size: "; echo ${coverity_token} | wc -c
           exit 0
           cov-build --dir cov-int ./test-builds.sh layer-02-maximus
           tar cfz cov-int.tar.gz cov-int

From e189c7987cf8fa639ca3c0d023bca9d1f2f7fd17 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Fri, 6 Dec 2024 22:43:22 +0000
Subject: [PATCH 14/42] use shell expansion

---
 .github/workflows/slow.yaml | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index 19ef383d195..5978fbc42eb 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -203,14 +203,10 @@ jobs:
       - name: Coverity Full Scan
         if: ${{ env.coverity_user }} && ${{ env.coverity_token }}
         run: |
-          echo "user: ${coverity_user}, token: ${coverity_token}"
-          echo -n "user size: "; echo ${coverity_user} | wc -c
-          echo -n "token size: "; echo ${coverity_token} | wc -c
-          exit 0
           cov-build --dir cov-int ./test-builds.sh layer-02-maximus
           tar cfz cov-int.tar.gz cov-int
           curl --form project=Squid \
             --form file=@cov-int.tar.gz \
-            --form token="${{ env.coverity_token }}" \
-            --form email="${{ env.coverity_user }}" \
+            --form token="${coverity_token}" \
+            --form email="${coverity_user}" \
             https://scan.coverity.com/builds
\ No newline at end of file

From 46173c6d40847f17d777c37c20285214c661246f Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Sat, 7 Dec 2024 14:47:05 +0000
Subject: [PATCH 15/42] change parameter specification

---
 .github/workflows/slow.yaml | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index 5978fbc42eb..2862d0801f8 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -202,11 +202,16 @@ jobs:
 
       - name: Coverity Full Scan
         if: ${{ env.coverity_user }} && ${{ env.coverity_token }}
+        env:
+          coverity_token: ${{ secrets.COVERITY_PASSPHRASE }}
+          coverity_user: ${{ secrets.COVERITY_USER }}
+
         run: |
           cov-build --dir cov-int ./test-builds.sh layer-02-maximus
-          tar cfz cov-int.tar.gz cov-int
-          curl --form project=Squid \
-            --form file=@cov-int.tar.gz \
-            --form token="${coverity_token}" \
-            --form email="${coverity_user}" \
-            https://scan.coverity.com/builds
\ No newline at end of file
+          tar caf cov-int.tar.xz cov-int
+          curl \
+            --form email=${coverity_user} \
+            --form token=${coverity_token} \
+            --form version=coverity_scan \
+            --form file=@cov-int.tar.xz \
+            https://scan.coverity.com/builds?project=Squid

From c685d6f10846c73d0f225e6ce9e1ffaf60da5e8a Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Sat, 7 Dec 2024 16:46:24 +0000
Subject: [PATCH 16/42] use secrets.COVERITY_TOKEN

---
 .github/workflows/slow.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index 2862d0801f8..29fd8590e6a 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -190,7 +190,7 @@ jobs:
     runs-on: ubuntu-22.04
     env:
       coverity_user: ${{ secrets.COVERITY_USER }}
-      coverity_token: ${{ secrets.COVERITY_PASSPHRASE }}
+      coverity_token: ${{ secrets.COVERITY_TOKEN }}
 
     container:
       image: squidcache/buildfarm-coverity:stable
@@ -203,8 +203,8 @@ jobs:
       - name: Coverity Full Scan
         if: ${{ env.coverity_user }} && ${{ env.coverity_token }}
         env:
-          coverity_token: ${{ secrets.COVERITY_PASSPHRASE }}
           coverity_user: ${{ secrets.COVERITY_USER }}
+          coverity_token: ${{ secrets.COVERITY_TOKEN }}
 
         run: |
           cov-build --dir cov-int ./test-builds.sh layer-02-maximus

From 6db5f6a1cc4399a871bb92126a7c8f98149b6c20 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Sat, 7 Dec 2024 16:46:51 +0000
Subject: [PATCH 17/42] try not specifying environment twice

---
 .github/workflows/slow.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index 29fd8590e6a..4b52ac06263 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -202,9 +202,9 @@ jobs:
 
       - name: Coverity Full Scan
         if: ${{ env.coverity_user }} && ${{ env.coverity_token }}
-        env:
-          coverity_user: ${{ secrets.COVERITY_USER }}
-          coverity_token: ${{ secrets.COVERITY_TOKEN }}
+        # env:
+        #   coverity_user: ${{ secrets.COVERITY_USER }}
+        #   coverity_token: ${{ secrets.COVERITY_TOKEN }}
 
         run: |
           cov-build --dir cov-int ./test-builds.sh layer-02-maximus

From 5743b0e8b655da53a91a67b2a099c48387a036f5 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Sat, 7 Dec 2024 18:06:48 +0000
Subject: [PATCH 18/42] ignore curl result

---
 .github/workflows/slow.yaml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index 4b52ac06263..22f4d508001 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -85,6 +85,7 @@ jobs:
     name: macos
     if: false
 
+
     steps:
       - name: Install prerequisite MacOS packages
         run: |
@@ -202,9 +203,6 @@ jobs:
 
       - name: Coverity Full Scan
         if: ${{ env.coverity_user }} && ${{ env.coverity_token }}
-        # env:
-        #   coverity_user: ${{ secrets.COVERITY_USER }}
-        #   coverity_token: ${{ secrets.COVERITY_TOKEN }}
 
         run: |
           cov-build --dir cov-int ./test-builds.sh layer-02-maximus
@@ -215,3 +213,4 @@ jobs:
             --form version=coverity_scan \
             --form file=@cov-int.tar.xz \
             https://scan.coverity.com/builds?project=Squid
+          true # ignore curl exit code

From e9ec7cacb4af4435c1fb81825e074e4a79a96b69 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Sat, 7 Dec 2024 18:11:16 +0000
Subject: [PATCH 19/42] better secret existence test

---
 .github/workflows/slow.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index 22f4d508001..e2307a399c1 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -202,7 +202,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Coverity Full Scan
-        if: ${{ env.coverity_user }} && ${{ env.coverity_token }}
+        if: ${{ env.coverity_user != '' }} && ${{ env.coverity_token != ''}}
 
         run: |
           cov-build --dir cov-int ./test-builds.sh layer-02-maximus

From f506fe35050a6ad845eb91cee7b81ff56b3a28bb Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Sat, 7 Dec 2024 18:14:54 +0000
Subject: [PATCH 20/42] try hoisting test to job level

---
 .github/workflows/slow.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index e2307a399c1..66ebf550a04 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -192,6 +192,7 @@ jobs:
     env:
       coverity_user: ${{ secrets.COVERITY_USER }}
       coverity_token: ${{ secrets.COVERITY_TOKEN }}
+    if: ${{ env.coverity_user != '' }} && ${{ env.coverity_token != '' }}
 
     container:
       image: squidcache/buildfarm-coverity:stable
@@ -202,7 +203,6 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Coverity Full Scan
-        if: ${{ env.coverity_user != '' }} && ${{ env.coverity_token != ''}}
 
         run: |
           cov-build --dir cov-int ./test-builds.sh layer-02-maximus

From 45fb4c815930b20d84e3a78e957d89ebb877d824 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Sat, 7 Dec 2024 18:17:43 +0000
Subject: [PATCH 21/42] different syntax

---
 .github/workflows/slow.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index 66ebf550a04..25f5b46a839 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -192,7 +192,6 @@ jobs:
     env:
       coverity_user: ${{ secrets.COVERITY_USER }}
       coverity_token: ${{ secrets.COVERITY_TOKEN }}
-    if: ${{ env.coverity_user != '' }} && ${{ env.coverity_token != '' }}
 
     container:
       image: squidcache/buildfarm-coverity:stable
@@ -203,7 +202,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Coverity Full Scan
-
+        if: env.coverity_user && env.coverity_token
         run: |
           cov-build --dir cov-int ./test-builds.sh layer-02-maximus
           tar caf cov-int.tar.xz cov-int

From c1a15f56525d2ddba5310988dfb8df771eed97f8 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Sat, 7 Dec 2024 18:21:00 +0000
Subject: [PATCH 22/42] rename step

---
 .github/workflows/slow.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index 25f5b46a839..a9fa0e2bcc7 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -201,7 +201,7 @@ jobs:
       - name: Checkout Sources
         uses: actions/checkout@v4
 
-      - name: Coverity Full Scan
+      - name: Scan with Coverity
         if: env.coverity_user && env.coverity_token
         run: |
           cov-build --dir cov-int ./test-builds.sh layer-02-maximus

From 495045c43882d587a7ed600beb16360c5549e96e Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Sat, 7 Dec 2024 18:28:42 +0000
Subject: [PATCH 23/42] rename, make all steps conditional

---
 .github/workflows/slow.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index a9fa0e2bcc7..beca3926e38 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -187,7 +187,7 @@ jobs:
           path: btlayer-*.log
 
   coverity-scan:
-    name: Coverity Scan
+    name: Scan with Coverity
     runs-on: ubuntu-22.04
     env:
       coverity_user: ${{ secrets.COVERITY_USER }}
@@ -199,9 +199,10 @@ jobs:
 
     steps:
       - name: Checkout Sources
+        if: env.coverity_user && env.coverity_token
         uses: actions/checkout@v4
 
-      - name: Scan with Coverity
+      - name: Scan
         if: env.coverity_user && env.coverity_token
         run: |
           cov-build --dir cov-int ./test-builds.sh layer-02-maximus

From f95ddc72b1197ddc4c18ec49c1a673b9bc0d3609 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Sat, 7 Dec 2024 18:33:47 +0000
Subject: [PATCH 24/42] add comment

---
 .github/workflows/slow.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index beca3926e38..7c41e6d66a8 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -189,6 +189,8 @@ jobs:
   coverity-scan:
     name: Scan with Coverity
     runs-on: ubuntu-22.04
+    # this job only runs if the github repository contains username
+    # and password to access the Coverity Scan service
     env:
       coverity_user: ${{ secrets.COVERITY_USER }}
       coverity_token: ${{ secrets.COVERITY_TOKEN }}

From 2787145e1552624268311da11058d7b8ec833e49 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Sat, 7 Dec 2024 18:36:29 +0000
Subject: [PATCH 25/42] reenable all jobs

---
 .github/workflows/slow.yaml | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index 7c41e6d66a8..71cc6b54e32 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -21,7 +21,6 @@ concurrency:
 
 jobs:
   linux-distros:
-    if: false
 
     strategy:
       matrix:
@@ -83,8 +82,6 @@ jobs:
   macos:
     runs-on: macos-14
     name: macos
-    if: false
-
 
     steps:
       - name: Install prerequisite MacOS packages
@@ -139,7 +136,6 @@ jobs:
           path: btlayer-*.log
 
   freebsd:
-    if: false
     strategy:
       matrix:
         osversion:

From eed1bf0397b905d3bbc6a476bc7e499374090e72 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Sat, 7 Dec 2024 20:07:18 +0000
Subject: [PATCH 26/42] Create scheduled workflow

---
 .github/workflows/scheduled.yaml | 44 ++++++++++++++++++++++++++++++++
 .github/workflows/slow.yaml      | 31 ----------------------
 2 files changed, 44 insertions(+), 31 deletions(-)
 create mode 100644 .github/workflows/scheduled.yaml

diff --git a/.github/workflows/scheduled.yaml b/.github/workflows/scheduled.yaml
new file mode 100644
index 00000000000..578e122fee8
--- /dev/null
+++ b/.github/workflows/scheduled.yaml
@@ -0,0 +1,44 @@
+# Tests in this workflow are run periodically.
+# They are generally very expensive and not on the critical path
+# for development
+
+# scheduled workwlows only run in the default branch
+on:
+  schedule:
+    - cron: "42 3 * * 0"
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  coverity-scan:
+    name: Scan with Coverity
+    runs-on: ubuntu-22.04
+    # this job only runs if the github repository contains username
+    # and password to access the Coverity Scan service
+    env:
+      coverity_user: ${{ secrets.COVERITY_USER }}
+      coverity_token: ${{ secrets.COVERITY_TOKEN }}
+
+    container:
+      image: squidcache/buildfarm-coverity:stable
+      options: --user 1001 # uid used by worfklow runner
+
+    steps:
+      - name: Checkout Sources
+        if: env.coverity_user && env.coverity_token
+        uses: actions/checkout@v4
+
+      - name: Scan
+        if: env.coverity_user && env.coverity_token
+        run: |
+          cov-build --dir cov-int ./test-builds.sh layer-02-maximus
+          tar caf cov-int.tar.xz cov-int
+          curl \
+            --form email=${coverity_user} \
+            --form token=${coverity_token} \
+            --form version=coverity_scan \
+            --form file=@cov-int.tar.xz \
+            https://scan.coverity.com/builds?project=Squid
+          true # ignore curl exit code
diff --git a/.github/workflows/slow.yaml b/.github/workflows/slow.yaml
index 71cc6b54e32..534b293543f 100644
--- a/.github/workflows/slow.yaml
+++ b/.github/workflows/slow.yaml
@@ -181,34 +181,3 @@ jobs:
         with:
           name: build-logs-freebsd-${{ matrix.osversion }}
           path: btlayer-*.log
-
-  coverity-scan:
-    name: Scan with Coverity
-    runs-on: ubuntu-22.04
-    # this job only runs if the github repository contains username
-    # and password to access the Coverity Scan service
-    env:
-      coverity_user: ${{ secrets.COVERITY_USER }}
-      coverity_token: ${{ secrets.COVERITY_TOKEN }}
-
-    container:
-      image: squidcache/buildfarm-coverity:stable
-      options: --user 1001 # uid used by worfklow runner
-
-    steps:
-      - name: Checkout Sources
-        if: env.coverity_user && env.coverity_token
-        uses: actions/checkout@v4
-
-      - name: Scan
-        if: env.coverity_user && env.coverity_token
-        run: |
-          cov-build --dir cov-int ./test-builds.sh layer-02-maximus
-          tar caf cov-int.tar.xz cov-int
-          curl \
-            --form email=${coverity_user} \
-            --form token=${coverity_token} \
-            --form version=coverity_scan \
-            --form file=@cov-int.tar.xz \
-            https://scan.coverity.com/builds?project=Squid
-          true # ignore curl exit code

From 7a8009eea24616e7e7838830d4583731e0afd7f0 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Sat, 7 Dec 2024 21:18:43 +0000
Subject: [PATCH 27/42] restrict scheduled workflow to the squid project main
 repository

---
 .github/workflows/scheduled.yaml | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/scheduled.yaml b/.github/workflows/scheduled.yaml
index 578e122fee8..6819c389c42 100644
--- a/.github/workflows/scheduled.yaml
+++ b/.github/workflows/scheduled.yaml
@@ -1,8 +1,10 @@
 # Tests in this workflow are run periodically.
 # They are generally very expensive and not on the critical path
 # for development
+# scheduled workflows only run in the default branch
+
+name: Scheduled Tests
 
-# scheduled workwlows only run in the default branch
 on:
   schedule:
     - cron: "42 3 * * 0"
@@ -14,6 +16,9 @@ concurrency:
 jobs:
   coverity-scan:
     name: Scan with Coverity
+    # only run the workflow on Squid's main repository
+    if: github.repository == 'squid-cache/squid'
+
     runs-on: ubuntu-22.04
     # this job only runs if the github repository contains username
     # and password to access the Coverity Scan service

From 862c221974491400615b0a17ffd1c90d84bedbe5 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Sun, 8 Dec 2024 21:58:14 +0000
Subject: [PATCH 28/42] scheduled -> coverity-scan

---
 .github/workflows/{scheduled.yaml => coverity-scan.yaml} | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename .github/workflows/{scheduled.yaml => coverity-scan.yaml} (100%)

diff --git a/.github/workflows/scheduled.yaml b/.github/workflows/coverity-scan.yaml
similarity index 100%
rename from .github/workflows/scheduled.yaml
rename to .github/workflows/coverity-scan.yaml

From 8b78ccd1094a141836c44d68c3fe5ebab8b412f2 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Sun, 8 Dec 2024 22:23:39 +0000
Subject: [PATCH 29/42] do not hide curl errors

---
 .github/workflows/scheduled.yaml | 45 ++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 .github/workflows/scheduled.yaml

diff --git a/.github/workflows/scheduled.yaml b/.github/workflows/scheduled.yaml
new file mode 100644
index 00000000000..bc191959a2b
--- /dev/null
+++ b/.github/workflows/scheduled.yaml
@@ -0,0 +1,45 @@
+# Tests in this workflow are run periodically.
+# They are generally very expensive and not on the critical path
+# for development
+# scheduled workflows only run in the default branch
+
+name: Scheduled Tests
+
+on:
+  schedule:
+    - cron: "42 3 * * 0"
+  workflow_dispatch:
+
+jobs:
+  coverity-scan:
+    name: Scan with Coverity
+    # only run the workflow on Squid's main repository
+    if: github.repository == 'squid-cache/squid'
+
+    runs-on: ubuntu-22.04
+    # this job only runs if the github repository contains username
+    # and password to access the Coverity Scan service
+    env:
+      coverity_user: ${{ secrets.COVERITY_USER }}
+      coverity_token: ${{ secrets.COVERITY_TOKEN }}
+
+    container:
+      image: squidcache/buildfarm-coverity:stable
+      options: --user 1001 # uid used by worfklow runner
+
+    steps:
+      - name: Checkout Sources
+        if: env.coverity_user && env.coverity_token
+        uses: actions/checkout@v4
+
+      - name: Scan
+        if: env.coverity_user && env.coverity_token
+        run: |
+          cov-build --dir cov-int ./test-builds.sh layer-02-maximus
+          tar caf cov-int.tar.xz cov-int
+          curl \
+            --form email=${coverity_user} \
+            --form token=${coverity_token} \
+            --form version=coverity_scan \
+            --form file=@cov-int.tar.xz \
+            https://scan.coverity.com/builds?project=Squid

From 2fe48ae970ba961119fecfbc9f09c7ddb57ebfb2 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Mon, 9 Dec 2024 21:11:52 +0000
Subject: [PATCH 30/42] do not test for secrets existence

---
 .github/workflows/coverity-scan.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/.github/workflows/coverity-scan.yaml b/.github/workflows/coverity-scan.yaml
index 6819c389c42..a32a1c1a291 100644
--- a/.github/workflows/coverity-scan.yaml
+++ b/.github/workflows/coverity-scan.yaml
@@ -7,7 +7,7 @@ name: Scheduled Tests
 
 on:
   schedule:
-    - cron: "42 3 * * 0"
+    - cron: "42 3 * * 0" # once a week
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
@@ -36,7 +36,6 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Scan
-        if: env.coverity_user && env.coverity_token
         run: |
           cov-build --dir cov-int ./test-builds.sh layer-02-maximus
           tar caf cov-int.tar.xz cov-int

From 7632ec584c27564a4a0efc7aa783a6f99af43662 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Mon, 9 Dec 2024 21:12:09 +0000
Subject: [PATCH 31/42] have curl return error on http error

---
 .github/workflows/coverity-scan.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/coverity-scan.yaml b/.github/workflows/coverity-scan.yaml
index a32a1c1a291..2f8d451c379 100644
--- a/.github/workflows/coverity-scan.yaml
+++ b/.github/workflows/coverity-scan.yaml
@@ -40,6 +40,7 @@ jobs:
           cov-build --dir cov-int ./test-builds.sh layer-02-maximus
           tar caf cov-int.tar.xz cov-int
           curl \
+            --fail-with-body \
             --form email=${coverity_user} \
             --form token=${coverity_token} \
             --form version=coverity_scan \

From 49371fbe71f2fd5dd991f705de5a3045a72e3669 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Mon, 9 Dec 2024 21:12:27 +0000
Subject: [PATCH 32/42] do not ignore curl errors

---
 .github/workflows/coverity-scan.yaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.github/workflows/coverity-scan.yaml b/.github/workflows/coverity-scan.yaml
index 2f8d451c379..855e990578d 100644
--- a/.github/workflows/coverity-scan.yaml
+++ b/.github/workflows/coverity-scan.yaml
@@ -46,4 +46,3 @@ jobs:
             --form version=coverity_scan \
             --form file=@cov-int.tar.xz \
             https://scan.coverity.com/builds?project=Squid
-          true # ignore curl exit code

From befbd413d181515cda0ffc57d374b4dd8f1fbbae Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Mon, 9 Dec 2024 21:13:06 +0000
Subject: [PATCH 33/42] do not test coverity secrets

---
 .github/workflows/coverity-scan.yaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.github/workflows/coverity-scan.yaml b/.github/workflows/coverity-scan.yaml
index 855e990578d..b83f1a30251 100644
--- a/.github/workflows/coverity-scan.yaml
+++ b/.github/workflows/coverity-scan.yaml
@@ -32,7 +32,6 @@ jobs:
 
     steps:
       - name: Checkout Sources
-        if: env.coverity_user && env.coverity_token
         uses: actions/checkout@v4
 
       - name: Scan

From 96d056eaf57375b25e7c05f578b8d92fc13ed040 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Mon, 9 Dec 2024 21:57:55 +0000
Subject: [PATCH 34/42] redo missing changes

---
 .github/workflows/coverity-scan.yaml | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/coverity-scan.yaml b/.github/workflows/coverity-scan.yaml
index b83f1a30251..f46c9fac4cf 100644
--- a/.github/workflows/coverity-scan.yaml
+++ b/.github/workflows/coverity-scan.yaml
@@ -3,15 +3,13 @@
 # for development
 # scheduled workflows only run in the default branch
 
-name: Scheduled Tests
+name: Coverity Scan
 
 on:
   schedule:
     - cron: "42 3 * * 0" # once a week
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
-  cancel-in-progress: true
+  # allows to run this workflow manually from the Actions tab
+  workflow_dispatch:
 
 jobs:
   coverity-scan:

From 555792e9560c8b30890e433c69af1a1e57a08ae3 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <5175948+kinkie@users.noreply.github.com>
Date: Thu, 12 Dec 2024 21:46:14 +0000
Subject: [PATCH 35/42] document workflow

Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
---
 .github/workflows/coverity-scan.yaml | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/coverity-scan.yaml b/.github/workflows/coverity-scan.yaml
index f46c9fac4cf..f49d00f4514 100644
--- a/.github/workflows/coverity-scan.yaml
+++ b/.github/workflows/coverity-scan.yaml
@@ -1,7 +1,6 @@
-# Tests in this workflow are run periodically.
-# They are generally very expensive and not on the critical path
-# for development
-# scheduled workflows only run in the default branch
+# Coverity Scan service terms limit analysis requests frequency, 
+# and the service runs analysis in the background. Thus, we submit
+# default branch analysis requests on a schedule rather than testing PRs.
 
 name: Coverity Scan
 

From f23252ffdb2fc9299266763411f7c493d92e2c40 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <5175948+kinkie@users.noreply.github.com>
Date: Thu, 12 Dec 2024 21:49:43 +0000
Subject: [PATCH 36/42] add a white line

Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
---
 .github/workflows/coverity-scan.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/coverity-scan.yaml b/.github/workflows/coverity-scan.yaml
index f49d00f4514..bca5ff3c210 100644
--- a/.github/workflows/coverity-scan.yaml
+++ b/.github/workflows/coverity-scan.yaml
@@ -7,6 +7,7 @@ name: Coverity Scan
 on:
   schedule:
     - cron: "42 3 * * 0" # once a week
+
   # allows to run this workflow manually from the Actions tab
   workflow_dispatch:
 

From 2c46242887bb237ed198c3e7ac28945feb7a7dfb Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <5175948+kinkie@users.noreply.github.com>
Date: Thu, 12 Dec 2024 21:50:10 +0000
Subject: [PATCH 37/42] update comment on requiring secrets

Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
---
 .github/workflows/coverity-scan.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/coverity-scan.yaml b/.github/workflows/coverity-scan.yaml
index bca5ff3c210..10dba9b347e 100644
--- a/.github/workflows/coverity-scan.yaml
+++ b/.github/workflows/coverity-scan.yaml
@@ -18,8 +18,9 @@ jobs:
     if: github.repository == 'squid-cache/squid'
 
     runs-on: ubuntu-22.04
-    # this job only runs if the github repository contains username
-    # and password to access the Coverity Scan service
+
+    # this job relies on GitHub repository configuration containing
+    # username and password to access the Coverity Scan service
     env:
       coverity_user: ${{ secrets.COVERITY_USER }}
       coverity_token: ${{ secrets.COVERITY_TOKEN }}

From fbad708736f8cbed60920519a93f9aa23331fdf3 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <5175948+kinkie@users.noreply.github.com>
Date: Thu, 12 Dec 2024 21:52:36 +0000
Subject: [PATCH 38/42] change comment wording

Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
---
 .github/workflows/coverity-scan.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/coverity-scan.yaml b/.github/workflows/coverity-scan.yaml
index 10dba9b347e..89fdb68726b 100644
--- a/.github/workflows/coverity-scan.yaml
+++ b/.github/workflows/coverity-scan.yaml
@@ -33,7 +33,7 @@ jobs:
       - name: Checkout Sources
         uses: actions/checkout@v4
 
-      - name: Scan
+      - name: Prepare and upload sources to Coverity Scan
         run: |
           cov-build --dir cov-int ./test-builds.sh layer-02-maximus
           tar caf cov-int.tar.xz cov-int

From 482f3cf08a65efbc621fd49f805d01356e6835fb Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Thu, 12 Dec 2024 21:58:30 +0000
Subject: [PATCH 39/42] Remove obsolete scheduled.yaml file

---
 .github/workflows/scheduled.yaml | 45 --------------------------------
 1 file changed, 45 deletions(-)
 delete mode 100644 .github/workflows/scheduled.yaml

diff --git a/.github/workflows/scheduled.yaml b/.github/workflows/scheduled.yaml
deleted file mode 100644
index bc191959a2b..00000000000
--- a/.github/workflows/scheduled.yaml
+++ /dev/null
@@ -1,45 +0,0 @@
-# Tests in this workflow are run periodically.
-# They are generally very expensive and not on the critical path
-# for development
-# scheduled workflows only run in the default branch
-
-name: Scheduled Tests
-
-on:
-  schedule:
-    - cron: "42 3 * * 0"
-  workflow_dispatch:
-
-jobs:
-  coverity-scan:
-    name: Scan with Coverity
-    # only run the workflow on Squid's main repository
-    if: github.repository == 'squid-cache/squid'
-
-    runs-on: ubuntu-22.04
-    # this job only runs if the github repository contains username
-    # and password to access the Coverity Scan service
-    env:
-      coverity_user: ${{ secrets.COVERITY_USER }}
-      coverity_token: ${{ secrets.COVERITY_TOKEN }}
-
-    container:
-      image: squidcache/buildfarm-coverity:stable
-      options: --user 1001 # uid used by worfklow runner
-
-    steps:
-      - name: Checkout Sources
-        if: env.coverity_user && env.coverity_token
-        uses: actions/checkout@v4
-
-      - name: Scan
-        if: env.coverity_user && env.coverity_token
-        run: |
-          cov-build --dir cov-int ./test-builds.sh layer-02-maximus
-          tar caf cov-int.tar.xz cov-int
-          curl \
-            --form email=${coverity_user} \
-            --form token=${coverity_token} \
-            --form version=coverity_scan \
-            --form file=@cov-int.tar.xz \
-            https://scan.coverity.com/builds?project=Squid

From 02dbd0403f8844e338af9a5a1d06859c93c470b0 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Thu, 12 Dec 2024 21:58:46 +0000
Subject: [PATCH 40/42] use extended options in call to tar

---
 .github/workflows/coverity-scan.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/coverity-scan.yaml b/.github/workflows/coverity-scan.yaml
index 89fdb68726b..9eb1142ba6a 100644
--- a/.github/workflows/coverity-scan.yaml
+++ b/.github/workflows/coverity-scan.yaml
@@ -36,7 +36,7 @@ jobs:
       - name: Prepare and upload sources to Coverity Scan
         run: |
           cov-build --dir cov-int ./test-builds.sh layer-02-maximus
-          tar caf cov-int.tar.xz cov-int
+          tar -c -a -f cov-int.tar.xz cov-int
           curl \
             --fail-with-body \
             --form email=${coverity_user} \

From 7dccbe14358c552d506416264acf1ec18afa7ba8 Mon Sep 17 00:00:00 2001
From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Thu, 12 Dec 2024 22:00:19 +0000
Subject: [PATCH 41/42] configuration -> secrets

---
 .github/workflows/coverity-scan.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/coverity-scan.yaml b/.github/workflows/coverity-scan.yaml
index 9eb1142ba6a..402f472ce02 100644
--- a/.github/workflows/coverity-scan.yaml
+++ b/.github/workflows/coverity-scan.yaml
@@ -19,7 +19,7 @@ jobs:
 
     runs-on: ubuntu-22.04
 
-    # this job relies on GitHub repository configuration containing
+    # this job relies on GitHub repository secrets containing
     # username and password to access the Coverity Scan service
     env:
       coverity_user: ${{ secrets.COVERITY_USER }}

From 8ef113a000598660a553ced24e12f6793ef930ea Mon Sep 17 00:00:00 2001
From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Thu, 12 Dec 2024 17:45:38 -0500
Subject: [PATCH 42/42] fixup: Removed trailing space

---
 .github/workflows/coverity-scan.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/coverity-scan.yaml b/.github/workflows/coverity-scan.yaml
index 402f472ce02..5bc4f9a656d 100644
--- a/.github/workflows/coverity-scan.yaml
+++ b/.github/workflows/coverity-scan.yaml
@@ -1,4 +1,4 @@
-# Coverity Scan service terms limit analysis requests frequency, 
+# Coverity Scan service terms limit analysis requests frequency,
 # and the service runs analysis in the background. Thus, we submit
 # default branch analysis requests on a schedule rather than testing PRs.