Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching causing succesful patches to not save to output #4

Open
aidanby opened this issue Feb 19, 2024 · 0 comments
Open

Caching causing succesful patches to not save to output #4

aidanby opened this issue Feb 19, 2024 · 0 comments
Assignees

Comments

@aidanby
Copy link
Collaborator

aidanby commented Feb 19, 2024

if(patchCache.containsKey(this.buggyProject + patchedFile)) {
fixedStatus = patchCache.get(this.buggyProject + patchedFile);
if(fixedStatus == FixStatus.SUCCESS) return FixStatus.SUCCESS;
continue;

Above lines in AbstractFixer causes successful patches to not save to output. Continues out of the loop without hitting postPatchAttemptCleanup() here:

postPatchAttemptCleanup(fixedStatus, scn, patch, buggyCode, patchCode, patchedFile);

@clegoues should I add a postPatchAttemptCleanup() call in this line . Or am I misunderstanding what you are trying to do here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants