Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of mock #149

Open
dvzrv opened this issue Nov 13, 2022 · 1 comment
Open

Remove the use of mock #149

dvzrv opened this issue Nov 13, 2022 · 1 comment

Comments

@dvzrv
Copy link

dvzrv commented Nov 13, 2022

Hi! I'm packaging this project for Arch Linux.

In the tests, this project makes extensive use of mock, which is deprecated in favor of unittest.mock (with Python >= 3.3).

I could open a PR for removing the use of mock in favor of unittest.mock, as I assume it does not make any sense to further support anything outside the range of supported Python versions (especially nothing below Python 3.3).

@dvzrv dvzrv mentioned this issue Nov 13, 2022
@dvzrv
Copy link
Author

dvzrv commented Nov 13, 2022

I saw that you are still testing against python 2.7. Maybe that is intentional? Either way, python2 has been deprecated for a very long time and is removed from most distributions by now.

In case you still want to be backwards compatible, you may use something similar to what I offered in #150.
I've just closed the PR again, as I am not willing to sign a CLA. Sorry.

archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Nov 13, 2022
…from checkdepends.

Add upstreamed (but pulled) patch to remove the use of mock:
square/pylink#149

git-svn-id: file:///srv/repos/svn-community/svn@1347282 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Nov 13, 2022
…from checkdepends.

Add upstreamed (but pulled) patch to remove the use of mock:
square/pylink#149

git-svn-id: file:///srv/repos/svn-community/svn@1347282 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant