Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniform type of WVData._vectors #5

Open
fginter opened this issue Dec 18, 2013 · 1 comment
Open

Uniform type of WVData._vectors #5

fginter opened this issue Dec 18, 2013 · 1 comment
Labels
enhancement

Comments

@fginter
Copy link
Collaborator

fginter commented Dec 18, 2013

This type is sometimes numpy's ndarray and sometimes a Python list, depending on the format of the model source file. Should we standardize on ndarray?
@spyysalo
Copy link
Owner

Yeah, this is definitely a problem. Agreed ndarray is the best choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spyysalo @fginter