Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): split payload service #796

Merged
merged 3 commits into from
Jun 21, 2024
Merged

refactor(core): split payload service #796

merged 3 commits into from
Jun 21, 2024

Conversation

timonback
Copy link
Member

prepares the future use of PayloadMethodReturnService

@netlify Netlify
Copy link

netlify bot commented Jun 9, 2024 •
edited
Loading

✅ Deploy Preview for springwolf-ui canceled.

Name Link
🔨 Latest commit 88406f5
🔍 Latest deploy log https://app.netlify.com/sites/springwolf-ui/deploys/66757e5ba13aad0008ac0d5d

@timonback timonback mentioned this pull request Jun 9, 2024
Merged
sam0r040
sam0r040 requested changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@sam0r040 sam0r040 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remarks, sorry for the mess with the payload service parameter names. We should check for occurences of payloadService before merging.
I am unsure about the internal package. Lets discuss next friday.

Overal the change looks good.

...src/main/java/io/github/springwolf/core/asyncapi/scanners/common/AsyncAnnotationScanner.java Outdated Show resolved Hide resolved
...src/main/java/io/github/springwolf/core/asyncapi/scanners/common/AsyncAnnotationScanner.java Outdated Show resolved Hide resolved
...ain/java/io/github/springwolf/core/asyncapi/scanners/common/ClassLevelAnnotationScanner.java Outdated Show resolved Hide resolved
...io/github/springwolf/core/asyncapi/scanners/common/payload/PayloadAsyncOperationService.java Show resolved Hide resolved
...o/github/springwolf/core/asyncapi/scanners/common/payload/PayloadMethodParameterService.java Show resolved Hide resolved
...java/io/github/springwolf/plugins/amqp/configuration/SpringwolfAmqpScannerConfiguration.java Outdated Show resolved Hide resolved
...java/io/github/springwolf/plugins/amqp/configuration/SpringwolfAmqpScannerConfiguration.java Outdated Show resolved Hide resolved
...java/io/github/springwolf/plugins/amqp/configuration/SpringwolfAmqpScannerConfiguration.java Outdated Show resolved Hide resolved
...n/java/io/github/springwolf/plugins/jms/configuration/SpringwolfJmsScannerConfiguration.java Outdated Show resolved Hide resolved
...n/java/io/github/springwolf/plugins/jms/configuration/SpringwolfJmsScannerConfiguration.java Outdated Show resolved Hide resolved
timonback added 2 commits June 21, 2024 14:36
@timonback
refactor(core): split payload service
735c21e 
prepares the future use of PayloadMethodReturnService
@timonback
chore(core): review comments
2131798
@timonback timonback force-pushed the refactor/split-payload-service branch from 5eed53d to 2131798 Compare June 21, 2024 13:13
@timonback timonback enabled auto-merge (squash) June 21, 2024 13:22
@timonback timonback requested a review from sam0r040 June 21, 2024 13:33
@timonback timonback merged commit 75ff837 into springwolf:master Jun 21, 2024
23 checks passed
@sam0r040 sam0r040 deleted the refactor/split-payload-service branch June 21, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam0r040 sam0r040 sam0r040 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timonback @sam0r040