Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Id generation fails for saveAll #1924

Closed
schauder opened this issue Oct 29, 2024 · 1 comment
Closed

Id generation fails for saveAll #1924

schauder opened this issue Oct 29, 2024 · 1 comment
Assignees
@schauder
Labels
type: regression A regression from a previous release
Milestone
3.4 GA (2024.1.0)

Comments

@schauder
Copy link
Contributor

The id generation via BeforeConvertCallback when saveAll is used.
@schauder schauder self-assigned this Oct 29, 2024
@schauder schauder added the type: regression A regression from a previous release label Oct 29, 2024
@schauder
Copy link
Contributor Author

This was caused by 7cf81ae

@schauder schauder added this to the 3.4 GA (2024.1.0) milestone Oct 29, 2024
schauder added a commit that referenced this issue Oct 29, 2024
@schauder
Polishing.
a351a66 
Using records in tests.
Removing "public" modifier in tests.

See #1924
schauder added a commit that referenced this issue Oct 29, 2024
@schauder
Remove code duplication.
a7cea62 
Mainly reimplements the changes undone in 49e343f.
The check for presence of the ID property is implemented for all variants for save, as it should.

See #1924
@schauder schauder mentioned this issue Oct 29, 2024
Closed
schauder added a commit that referenced this issue Nov 18, 2024
@schauder
Remove code duplication.
6eed53f 
Mainly reimplements the changes undone in 49e343f.
The check for presence of the ID property is implemented for all variants for save, as it should.

See #1924
Original pull request #1925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schauder schauder

Labels
type: regression A regression from a previous release
Projects
None yet
Milestone
3.4 GA (2024.1.0)
Development

No branches or pull requests
1 participant
@schauder