Add sqlite support #1770
Open
Add sqlite support #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
This was referenced Apr 14, 2024
mp911de
added
type: enhancement
mp911de
requested changes
Apr 15, 2024
spring-data-r2dbc/src/main/java/org/springframework/data/r2dbc/dialect/DialectResolver.java
Outdated
Show resolved
Hide resolved
...relational/src/main/java/org/springframework/data/relational/core/dialect/SQLiteDialect.java
Outdated
Show resolved
Hide resolved
...relational/src/main/java/org/springframework/data/relational/core/dialect/SQLiteDialect.java
Outdated
Show resolved
Hide resolved
...relational/src/main/java/org/springframework/data/relational/core/dialect/SQLiteDialect.java
Outdated
Show resolved
Hide resolved
...relational/src/main/java/org/springframework/data/relational/core/dialect/SQLiteDialect.java
Outdated
Show resolved
Hide resolved
|
We discussed this effort as a team and concluded two things:
Once the second item is addressed we can look for a way to integrate the dialect. For the time being, if you keep the code on your project, you can use the |
|
Any update on the subject ? |
mipo256
suggested changes
Nov 10, 2024
|
|
||
| @Override | ||
| public String getOffset(long offset) { | ||
| throw new UnsupportedOperationException("offset alone not supported"); |
There was a problem hiding this comment.
I think we can do better, like LIMIT -1 OFFSET %d. According to official documentation it is fine to set LIMIT to the negative value.
| } | ||
|
|
||
| @WritingConverter | ||
| private enum LocalDateTimeToNumericConverter implements Converter<LocalDateTime, Long> { |
There was a problem hiding this comment.
- We need to handle other JSR310 types as well.
- Can we safely assign UTC as a timezone to the
LocalDateTime? I do not think so. I think we should not introduce the converters forLocalDate/LocalTime/LocalDateTimehere, since we can cause bugs for users. It is better for them that the framework would not handle these types out of the box, rather than saving them assuming the UTC
| @Override | ||
| public Collection<Object> getConverters() { | ||
| Collection<Object> converters = new ArrayList<>(super.getConverters()); | ||
| converters.add(LocalDateTimeToNumericConverter.INSTANCE); |
There was a problem hiding this comment.
I didn't tried this dialect, but since sqlite, doesn't support boolean tye the same as everyone else, we should probably add a conversion for this too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to contribute with an SQL dialect for the project. I have tested it on my system and it works.