Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick List per Shipment #83

Open
rposborne opened this issue May 3, 2015 · 4 comments
Open

Pick List per Shipment #83

rposborne opened this issue May 3, 2015 · 4 comments

Comments

@rposborne
Copy link

Currently it appears this gem targets an entire order. What are thoughts on changing / extending support for a print pick list for each shipment in an order?

@rposborne rposborne changed the title Pick List per Shipement Pick List per Shipment May 3, 2015
@futhr
Copy link
Contributor

futhr commented May 3, 2015

@rposborne +1

@rposborne
Copy link
Author

@futhr How should we go about this. It feels weird to extend the API shipments controller to render out out a get PDF. Or should we outright add a shipment controller in backends scope?

@tvdeyen
Copy link
Contributor

tvdeyen commented May 4, 2015

I would definitely vote for a separate shipments controller. Therefore we can keep the order based documents and can have additional for shipments. We need then to also patch the shipment model, since as with the order, that's where the PDF rendering happens. So extracting the PDF generation out into a module would be best option IMO.

@mamhoff
Copy link
Contributor

mamhoff commented Jul 7, 2015

#87 will allow you to create PDFs for arbitrary Spree Models, among them Shipments. Because yes, what you want makes complete sense: A packaging slip for a shipment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants