Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3-0-stable NotImplementedError (You must implement cancel method for this payment method.) #171

Open
simontseng opened this issue Jul 6, 2015 · 4 comments

Comments

@simontseng
Copy link
Contributor

looks like spree is required some thing to be implemented now

NotImplementedError (You must implement cancel method for this payment method.):
vendor/bundle/ruby/2.2.0/gems/spree_core-3.0.1/app/models/spree/payment_method.rb:69:in `cancel'
vendor/bundle/ruby/2.2.0/gems/spree_core-3.0.1/app/models/spree/payment/processing.rb:72:in `cancel!'
vendor/bundle/ruby/2.2.0/gems/spree_core-3.0.1/app/models/spree/order.rb:631:in `block in after_cancel'
vendor/bundle/ruby/2.2.0/gems/activerecord-4.2.3/lib/active_record/relation/delegation.rb:46:in `each'
vendor/bundle/ruby/2.2.0/gems/activerecord-4.2.3/lib/active_record/relation/delegation.rb:46:in `each'
...

any suggestion about this

@simontseng
Copy link
Contributor Author

Does anyone here have the same issues? I would expect this affects everybody. Would love to see some discussion here and I don't mind to put in a PR just need someone point me in the right direction.

anybody?

@leokra
Copy link

leokra commented Aug 5, 2015

I get the same exception when trying to "Cancel" an already paid order in the backend (spree-2-4). And in "app/models/spree/gateway/pay_pal_express.rb" is no cancel-method implemented.

I'm not sure why not. Wouldn't it make sense to call the already existing refund-method, if the payment is successfully executed and an order cancelled?

@simontseng
Copy link
Contributor Author

+1 for fix

On Aug 5, 2015, at 6:50 PM, leokra [email protected] wrote:

I get the same exception when trying to "Cancel" an already paid order in the backend (spree-2-4). And in "app/models/spree/gateway/pay_pal_express.rb" is no cancel-method implemented.

I'm not sure why not. Wouldn't it make sense to call the already existing refund-method, if the payment is successfully executed and an order cancelled?


Reply to this email directly or view it on GitHub #171 (comment).

@SudeepSidhu
Copy link

#180 created for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants