Skip to content
This repository has been archived by the owner on Aug 31, 2022. It is now read-only.

Configure forking context with conf file #103

Closed
labianchin opened this issue Jul 9, 2018 · 3 comments
Closed

Configure forking context with conf file #103

labianchin opened this issue Jul 9, 2018 · 3 comments

Comments

@labianchin
Copy link
Contributor

Currently forking can be disabled with environment variable FLO_FORKING=false.

I would be great to have this configuration in typesafe config, like defining something in reference.conf:

flo.forkingEnabled=true
flo.forkingEnalbed=${?FLO_FORKING_ENABLED}
@rouzwawi
Copy link
Member

rouzwawi commented Jul 9, 2018

How about also disabling it by default? Seems to be the cause of a number of bugs lately: #100 #101 #102.

Object serialization and JVM forking is tricky, so we should let ForkingContext accumulate some mileage before being enabled by default.

@rouzwawi
Copy link
Member

Merged #104 now. Seems it missed 0.2.11 though.

@danielnorberg
Copy link
Contributor

This has been released. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants