Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

Stop using Guava's immutable collection types in public getters? #930

Open
davidxia opened this issue Nov 16, 2017 · 2 comments
Open

Stop using Guava's immutable collection types in public getters? #930

davidxia opened this issue Nov 16, 2017 · 2 comments
Labels
pinned exempt from being marked as stale question

Comments

@davidxia
Copy link
Contributor

This library can cause issues for projects that use its shaded jar and a different version of guava. Should we make a breaking change and stop using Guava's immutable collection types in public getters?

See spotify/helios#1142

@johnflavin
Copy link
Contributor

I know that when the abstract getters return Immutable* collection types, AutoValue will generate implementations that also use the Immutable* types. Do you know what collection types AutoValue will generate if your abstract getters do not return the Immutable* types?

I don't know if this matters.

@stale
Copy link

stale bot commented Sep 24, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pinned exempt from being marked as stale question
Projects
None yet
Development

No branches or pull requests

2 participants