Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

listTasks should allow list of values in each filter #1092

Open
davidxia opened this issue Oct 4, 2018 · 1 comment
Open

listTasks should allow list of values in each filter #1092

davidxia opened this issue Oct 4, 2018 · 1 comment
Labels
bug help wanted pinned exempt from being marked as stale

Comments

@davidxia
Copy link
Contributor

davidxia commented Oct 4, 2018

Description

bug report

How to reproduce

The implementation of listTasks(Task.Criteria) here

docker-client/src/main/java/com/spotify/docker/client/DefaultDockerClient.java

Line 2057 in e1c7d47

filters.put("id", Collections.singletonList(criteria.taskId()));
only allows one value for each filter. API docs state the value of each filter can be a list.

What do you expect

Allow a list of strings for each filter.

Software:

  • docker version: API 1.24+
  • Spotify's docker-client version: all
@davidxia davidxia added bug help wanted pinned exempt from being marked as stale labels Oct 4, 2018
@dmandalidis dmandalidis mentioned this issue Oct 1, 2019
Closed
@dmandalidis
Copy link
Contributor

I think you can close this (copied to dmandalidis/docker-client#1)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug help wanted pinned exempt from being marked as stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidxia @dmandalidis