Additionally run on macos and only run javap on linux as not really needed #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #1116 |
github didn't add path on windows, this item is not super important IMO as gradle should compile correctly so there is no real reason to check it worked properly. However, will keep it for now but limiting it to just one OS as checking numerous times is again IMO worthless.
|
@KengoTODA going to merge so repo is back to working order. If any concerns on the change, let me know. |
|
🎉 This PR is included in version 6.0.8 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: The windows update done on github no longer has PATH set. Thus the failure. I don't see much value in javap here. I think gradle should be ensuring its setup correctly not some post action to confirm. As such, rather than trying to fix the path (note it runs on macos ok with path), just make it run on linux only for that step as good enough.